[FIX] RML reporting: understandable crash message
authorRichard Mathot <rim@openerp.com>
Wed, 2 Jul 2014 15:29:13 +0000 (17:29 +0200)
committerRichard Mathot <rim@openerp.com>
Wed, 2 Jul 2014 15:30:32 +0000 (17:30 +0200)
When tag <drawString> is misused in an RML report, logs a more explicit
error

openerp/report/render/rml2pdf/trml2pdf.py

index 9ed1a14..ec5e948 100644 (file)
@@ -373,7 +373,11 @@ class _rml_canvas(object):
         v = utils.attr_get(node, ['x','y'])
         text=self._textual(node, **v)
         text = utils.xml2str(text)
-        self.canvas.drawString(text=text, **v)
+        try:
+            self.canvas.drawString(text=text, **v)
+        except TypeError as e:
+            _logger.error("Bad RML: <drawReport> tag requires attributes 'x' and 'y'!")
+            raise e
 
     def _drawCenteredString(self, node):
         v = utils.attr_get(node, ['x','y'])