[FIX] gamification: do not set a start_date by default as the cron starts past challe...
authorMartin Trigaux <mat@openerp.com>
Thu, 24 Apr 2014 11:03:41 +0000 (13:03 +0200)
committerMartin Trigaux <mat@openerp.com>
Thu, 24 Apr 2014 11:03:41 +0000 (13:03 +0200)
bzr revid: mat@openerp.com-20140424110341-pnu79q44m7gzl8t0

addons/gamification/models/challenge.py

index 8ac7753..b532232 100644 (file)
@@ -199,7 +199,6 @@ class gamification_challenge(osv.Model):
         'visibility_mode': 'personal',
         'report_message_frequency': 'never',
         'last_report_date': fields.date.today,
-        'start_date': fields.date.today,
         'manager_id': lambda s, cr, uid, c: uid,
         'category': 'hr',
         'reward_failure': False,
@@ -284,13 +283,15 @@ class gamification_challenge(osv.Model):
         planned_challenge_ids = self.search(cr, uid, [
             ('state', '=', 'draft'),
             ('start_date', '<=', fields.date.today())])
-        self.write(cr, uid, planned_challenge_ids, {'state': 'inprogress'}, context=context)
+        if planned_challenge_ids:
+            self.write(cr, uid, planned_challenge_ids, {'state': 'inprogress'}, context=context)
 
         # close planned challenges
         planned_challenge_ids = self.search(cr, uid, [
             ('state', '=', 'inprogress'),
             ('end_date', '>=', fields.date.today())])
-        self.write(cr, uid, planned_challenge_ids, {'state': 'done'}, context=context)
+        if planned_challenge_ids:
+            self.write(cr, uid, planned_challenge_ids, {'state': 'done'}, context=context)
 
         if not ids:
             ids = self.search(cr, uid, [('state', '=', 'inprogress')], context=context)