[IMP]:optimize the code

bzr revid: ksa@tinyerp.com-20120215113039-jun1g46j3j2c8zp2

diff --git a/addons/account/invoice.py b/addons/account/invoice.py
index fc4e5fb..02d04e1 100644 (file)
--- a/addons/account/invoice.py
+++ b/addons/account/invoice.py
@@ -751,13 +751,10 @@ class account_invoice(osv.osv):
                 if not number:
                     raise osv.except_osv(_('Warning !'), _('There is no active invoice sequence defined for the journal !'))
 
+                ref = self._convert_ref(cr, uid, number)
                 if invtype in ('in_invoice', 'in_refund'):
-                    if not reference:
-                        ref = self._convert_ref(cr, uid, number)
-                    else:
+                    if reference:
                         ref = reference
-                else:
-                    ref = self._convert_ref(cr, uid, number)
                 cr.execute('UPDATE account_invoice SET number=%s ' \
                         'WHERE id=%s', (number, id))
                 cr.execute('UPDATE account_move SET ref=%s ' \