projects
/
odoo
/
odoo.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
536d00d
)
[IMP] models: add check for common conversion error in field definitions
author
Raphael Collet
<rco@openerp.com>
Tue, 2 Dec 2014 13:54:24 +0000
(14:54 +0100)
committer
Raphael Collet
<rco@openerp.com>
Wed, 3 Dec 2014 08:55:17 +0000
(09:55 +0100)
openerp/models.py
patch
|
blob
|
history
diff --git
a/openerp/models.py
b/openerp/models.py
index
33327ef
..
ad91afe
100644
(file)
--- a/
openerp/models.py
+++ b/
openerp/models.py
@@
-241,6
+241,11
@@
class MetaModel(api.Meta):
if not self._custom:
self.module_to_models.setdefault(self._module, []).append(self)
if not self._custom:
self.module_to_models.setdefault(self._module, []).append(self)
+ # check for new-api conversion error: leave comma after field definition
+ for key, val in attrs.iteritems():
+ if type(val) is tuple and len(val) == 1 and isinstance(val[0], Field):
+ _logger.error("Trailing comma after field definition: %s.%s", self, key)
+
# transform columns into new-style fields (enables field inheritance)
for name, column in self._columns.iteritems():
if name in self.__dict__:
# transform columns into new-style fields (enables field inheritance)
for name, column in self._columns.iteritems():
if name in self.__dict__: