[FIX] Forgotten ',' and issue on calling _push_event
authorvta vta@openerp.com <>
Wed, 9 Jan 2013 09:50:49 +0000 (10:50 +0100)
committervta vta@openerp.com <>
Wed, 9 Jan 2013 09:50:49 +0000 (10:50 +0100)
bzr revid: vta@openerp.com-20130109095049-4gb392x20iius6pj

addons/web_analytics/static/src/js/web_analytics.js

index 8d4c87d..4777d14 100644 (file)
@@ -23,7 +23,7 @@ openerp.web_analytics = function(instance) {
 
     instance.web_analytics.Tracker = instance.web.Class.extend({
         /*
-        *  This method initializes the tracker
+        * This method initializes the tracker
         */
         init: function() {
             /* Comment this lines when going on production, only used for testing on localhost
@@ -82,6 +82,44 @@ openerp.web_analytics = function(instance) {
                 });
         },
         /*
+        * Method called in order to send _trackEvent to GA
+        */
+        _push_event: function(options) {
+            _gaq.push(['_trackEvent',
+                options.category,
+                options.action,
+                options.label,
+                options.value,
+                options.noninteraction
+            ]);
+        },
+        /*
+        * Method called in order to send ecommerce transactions to GA
+        */
+        _push_ecommerce: function(trans_data, item_list) {
+            _gaq.push(['_addTrans',
+                trans_data.order_id,
+                trans_data.store_name,
+                trans_data.total,
+                trans_data.tax,
+                trans_data.shipping,
+                trans_data.city,
+                trans_data.state,
+                trans_data.country,
+            ]);
+            _.each(item_list, function(item) {
+                _gaq.push(['_addItem',
+                    item.order_id,
+                    item.sku,
+                    item.name,
+                    item.category,
+                    item.price,
+                    item.quantity,
+                ]);
+            });
+            _gaq.push(['_trackTrans']);
+        },
+        /*
         *  This method contains the initialization of the object and view type
         *  as an event in GA.
         */
@@ -194,44 +232,6 @@ openerp.web_analytics = function(instance) {
                 },
             });
         },
-        /*
-        * Method called in order to send _trackEvent to GA
-        */
-        _push_event: function(options) {
-            _gaq.push(['_trackEvent',
-                options.category,
-                options.action,
-                options.label,
-                options.value,
-                options.noninteraction
-            ]);
-        },
-        /*
-        * Method called in order to send ecommerce transactions to GA
-        */
-        _push_ecommerce: function(trans_data, item_list) {
-            _gaq.push(['_addTrans',
-                trans_data.order_id,
-                trans_data.store_name,
-                trans_data.total,
-                trans_data.tax,
-                trans_data.shipping,
-                trans_data.city,
-                trans_data.state
-                trans_data.country,
-            ]);
-            _.each(item_list, function(item) {
-                _gaq.push(['_addItem',
-                    item.order_id,
-                    item.sku,
-                    item.name,
-                    item.category,
-                    item.price,
-                    item.quantity,
-                ]);
-            });
-            _gaq.push(['_trackTrans']);
-        },
     });
 
     // ----------------------------------------------------------------