[DOC] web: search view: extra info about key events handling
authorOlivier Dony <odo@openerp.com>
Mon, 24 Nov 2014 17:45:22 +0000 (18:45 +0100)
committerOlivier Dony <odo@openerp.com>
Mon, 24 Nov 2014 17:50:35 +0000 (18:50 +0100)
Complements bde1a4432fef4cb2f5fe8ab600e72ab5b8b4830d

addons/web/static/src/js/search.js

index e1b96d5..82ba081 100644 (file)
@@ -2362,6 +2362,8 @@ instance.web.search.AutoComplete = instance.web.Widget.extend({
                 ev.preventDefault();
                 return;
             }
+            // ENTER is caugth at KeyUp rather than KeyDown to avoid firing
+            // before all regular keystrokes have been processed
             if (ev.which === $.ui.keyCode.ENTER) {
                 if (self.current_result && self.get_search_string().length) {
                     self.select_item(ev);
@@ -2382,6 +2384,9 @@ instance.web.search.AutoComplete = instance.web.Widget.extend({
         });
         this.$input.on('keydown', function (ev) {
             switch (ev.which) {
+                // TAB and direction keys are handled at KeyDown because KeyUp
+                // is not guaranteed to fire.
+                // See e.g. https://github.com/aef-/jquery.masterblaster/issues/13
                 case $.ui.keyCode.TAB:
                     if (self.current_result && self.get_search_string().length) {
                         self.select_item(ev);