From: Raphael Collet <rco@openerp.com>
Date: Tue, 2 Dec 2014 13:54:24 +0000 (+0100)
Subject: [IMP] models: add check for common conversion error in field definitions
X-Git-Url: http://git.inspyration.org/?p=odoo%2Fodoo.git;a=commitdiff_plain;h=d82aa69cccd7ce91389c915c8ffb6b0559db2ca5

[IMP] models: add check for common conversion error in field definitions
---

diff --git a/openerp/models.py b/openerp/models.py
index 33327ef..ad91afe 100644
--- a/openerp/models.py
+++ b/openerp/models.py
@@ -241,6 +241,11 @@ class MetaModel(api.Meta):
         if not self._custom:
             self.module_to_models.setdefault(self._module, []).append(self)
 
+        # check for new-api conversion error: leave comma after field definition
+        for key, val in attrs.iteritems():
+            if type(val) is tuple and len(val) == 1 and isinstance(val[0], Field):
+                _logger.error("Trailing comma after field definition: %s.%s", self, key)
+
         # transform columns into new-style fields (enables field inheritance)
         for name, column in self._columns.iteritems():
             if name in self.__dict__: