From 2b192bef2242c71d0ff3a45b9efb9e717fd364c4 Mon Sep 17 00:00:00 2001 From: Christophe Simonis Date: Thu, 16 Oct 2014 15:50:26 +0200 Subject: [PATCH] [FIX] report: do not fail if PDF cannot be saved as attachment due to AccessError --- addons/report/models/report.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/addons/report/models/report.py b/addons/report/models/report.py index c2e1cd2..16adc51 100644 --- a/addons/report/models/report.py +++ b/addons/report/models/report.py @@ -20,6 +20,7 @@ ############################################################################## from openerp import api +from openerp.exceptions import AccessError from openerp.osv import osv from openerp.tools import config, which from openerp.tools.translate import _ @@ -453,9 +454,14 @@ class Report(osv.Model): 'res_model': save_in_attachment.get('model'), 'res_id': reporthtml[0], } - self.pool['ir.attachment'].create(cr, uid, attachment) - _logger.info('The PDF document %s is now saved in the ' - 'database' % attachment['name']) + try: + self.pool['ir.attachment'].create(cr, uid, attachment) + except AccessError: + _logger.warning("Cannot save PDF report %r as attachment", + attachment['name']) + else: + _logger.info('The PDF document %s is now saved in the database', + attachment['name']) pdfdocuments.append(pdfreport_path) except: -- 1.7.10.4