Christophe Simonis [Thu, 11 Sep 2014 11:18:22 +0000 (13:18 +0200)]
[IMP] website_blog: more generic xpath expression when inheriting view. ease migration.
Ronak Baxi [Wed, 27 Aug 2014 09:55:20 +0000 (15:25 +0530)]
[FIX] web: scroll should move top on clicking menu on top bar
Backported from
97d99d1974c965506ed9005d4854fcc5ffee0590
Raphael Collet [Thu, 11 Sep 2014 08:31:10 +0000 (10:31 +0200)]
[FIX] fields: in computed fields, handle AccessError and MissingError
When computing a field on a recordset, a subset of the records may be missing
or forbidden by access rules. In that case, evaluate the compute method record
by record, and mark failed records as such in cache.
Simon Lejeune [Thu, 11 Sep 2014 08:55:59 +0000 (10:55 +0200)]
[FIX] website_forum: header template: double display of questions
The <t t-raw='0'/> is already defined lower in the view (line 101)
Simon Lejeune [Wed, 10 Sep 2014 12:59:00 +0000 (14:59 +0200)]
[FIX] web: about odoo: correct bootstrap structure inside the modal
Bootstrap's container class has a fixed width, using it in a modal
with the previous commit allowing an horizontal scrollbar makes the
layout goes crazy. Use container-fluid instead and cleaned some css.
Simon Lejeune [Wed, 10 Sep 2014 10:20:16 +0000 (12:20 +0200)]
[FIX] web: modals: overflow-x on modal-body to prevent large content to be displayed outside
Raphael Collet [Wed, 10 Sep 2014 12:55:28 +0000 (14:55 +0200)]
[FIX] models: in onchange(), do not send a field value if it has not changed
The method onchange() executes onchange methods in cascade. Suppose onchange()
is called and a field F=1 in the form. If an onchange method set F=2, that
value is put in the result variable. If another onchange method set it back to
F=1, the binding F=2 must be removed from the result variable.
Fixes #2309
Martin Trigaux [Thu, 11 Sep 2014 07:32:59 +0000 (09:32 +0200)]
[IMP] point_of_sale: field company_id on pos.config view
Move invisible field on bottom to avoid blank space in view if display journal, group or sequence field
Jeremy Kersten [Wed, 10 Sep 2014 17:50:22 +0000 (19:50 +0200)]
Jeremy Kersten [Wed, 10 Sep 2014 16:20:54 +0000 (18:20 +0200)]
[FIX] website_blog: change group restriction to load the JS editor
Jeremy Kersten [Wed, 10 Sep 2014 16:10:25 +0000 (18:10 +0200)]
[FIX] website_blog: wait that document is ready before to check if we need to update menu for blog
Jeremy Kersten [Wed, 10 Sep 2014 15:23:19 +0000 (17:23 +0200)]
[FIX] website_event_track: force type from related to fix bug with convert_to_cache on picture
Olivier Dony [Wed, 10 Sep 2014 15:01:38 +0000 (17:01 +0200)]
[FIX] mrp: force default values for dropped fields
Those values were dropped at rev 9b34358 but
need to be forced to empty so older databases
get fixed when upgrading
Olivier Dony [Wed, 10 Sep 2014 14:35:03 +0000 (16:35 +0200)]
[FIX] sale: force default values for dropped fields
Those values were dropped at rev 3b636a5 but
need to be forced back to default so older
databases get properly updated when upgrading.
Pankaj Joshi [Wed, 3 Sep 2014 13:37:41 +0000 (19:07 +0530)]
[FIX] hr_recruitment: fixed computation and storage of day_open and day_close + assignment of date_open and date_closed.
Olivier Dony [Wed, 10 Sep 2014 12:58:25 +0000 (14:58 +0200)]
[FIX] product,purchase,point_of_sale: force empty values for dropped fields
At 96f038a product-related fields were removed due
to an important product.template/product.product
refactoring. As the field values were simply
dropped, they may not be nullified when upgrading an
existing database. Forcing them to False will take
care of it.
Olivier Dony [Wed, 10 Sep 2014 12:55:08 +0000 (14:55 +0200)]
[FIX] mrp: force empty values for fields that were dropped
This ensures the field values are cleared during
upgrades from previous versions
Frederic van der Essen [Wed, 10 Sep 2014 12:34:58 +0000 (14:34 +0200)]
[FIX] point_of_sale: chrome was dropping the cookie when loading the company logo, resulting in an incorrect logo in multi-db setups.
Raphael Collet [Wed, 10 Sep 2014 10:10:22 +0000 (12:10 +0200)]
[FIX] models: in method onchange(), check for record dirtiness only on *2many fiels
Cascading onchanges can be caused by a related field computed in cache. This
causes a bug in sale order lines, were setting the uom field forces reading
product fields, which are inherited from product templates. The inherited
fields are computed as related fields, which marks the product record as dirty.
This subsequently triggers an onchange on the product field, which resets the
uom field!
Frederic van der Essen [Wed, 10 Sep 2014 11:52:04 +0000 (13:52 +0200)]
[FIX] point_of_sale: prevent the company logo from being cached by the browser by accessing it via a random URL
Simon Lejeune [Wed, 10 Sep 2014 11:42:35 +0000 (13:42 +0200)]
[FIX] web: revert
9f0834771d49a
Revert "[FIX] web: base.css: fixed width for input of file type under oe_avatar"
A better fix for opw-613318 is done in
f8bd25c852e
Denis Ledoux [Wed, 10 Sep 2014 11:12:21 +0000 (13:12 +0200)]
[FIX] web: FieldBinaryImage upload file at the right place
Before this, the div wasn't in the right place in the form view
for instance, in the product form view, the third checkbox triggered this binary upload file
opw-613318
task-8982
eneldoserrata [Mon, 8 Sep 2014 16:21:46 +0000 (12:21 -0400)]
[ADD] l10n_do: Chart of Account for Dominican Republic
Fixes #2257
Josse Colpaert [Wed, 10 Sep 2014 09:49:09 +0000 (11:49 +0200)]
Merge pull request #2312 from odoo-dev/8.0-wmsoptimassignrereserve-jco
[IMP] Add possibity to add rereserve button and optimize action assign
Josse Colpaert [Wed, 10 Sep 2014 09:23:48 +0000 (11:23 +0200)]
[IMP] Add possibity to add rereserve button and optimize action assign
Christophe Matthieu [Wed, 10 Sep 2014 08:30:25 +0000 (10:30 +0200)]
[FIX] website_sale: Price of accessory product are all time null. Need to use new api to send the context.
Christophe Matthieu [Thu, 4 Sep 2014 13:30:42 +0000 (15:30 +0200)]
[FIX] website_event_sale: need to use new api to send the context. Add some step for test to check if the cart have the distinct products
Christophe Matthieu [Thu, 4 Sep 2014 13:30:18 +0000 (15:30 +0200)]
[FIX] website.editor: need to set the range on start because the browser can be lost the caret and can't insert the media in the page.
Raphael Collet [Tue, 9 Sep 2014 13:23:52 +0000 (15:23 +0200)]
[FIX] openerp/osv/fields: disable prefetching when reading inverse of one2many fields
This fixes issue #2146. The inverse of a one2many field can be an inherited
field (_inherits). In that case, we cannot read its value with a simple
database query. Instead, we let the related field read it, but for performance
considerations we disable the prefetching of other fields.
Olivier Dony [Tue, 9 Sep 2014 17:20:44 +0000 (19:20 +0200)]
[FIX] mrp: force empty domain to reset action at upgrade
There was a domain in 7.0 but it must be forced
to empty during upgrade, as the MRP BoM model
has changed.
Jérome Maes [Fri, 5 Sep 2014 12:43:20 +0000 (14:43 +0200)]
[FIX] im_chat : search user method, split the sql query into 3 smaller
Raphael Collet [Tue, 9 Sep 2014 14:28:08 +0000 (16:28 +0200)]
[FIX] web: invoke fields_view_get with kwargs instead of positional args
The mapping old api → new api mistakenly takes the last positional argument as
the context (fields_view_get() has an extra parameter after context.)
Fixes issue #2063
Jeremy Kersten [Tue, 9 Sep 2014 14:51:35 +0000 (16:51 +0200)]
[IMP] crm: Use cookies to save utm instead of session.
Jeremy Kersten [Tue, 9 Sep 2014 14:50:42 +0000 (16:50 +0200)]
[FIX] website_sale: typo in tour
Frederic van der Essen [Tue, 9 Sep 2014 14:14:27 +0000 (16:14 +0200)]
[FIX] point_of_sale: display an error when trying to print a receipt on an outdated posbox
Commandant Custo [Tue, 9 Sep 2014 13:02:18 +0000 (15:02 +0200)]
[IMP] product: Order product.template by name
When no order is forced, it's more user-friendly if the products are ordered by alphabetical order.
This will mainly be applied:
* In the list view in the back-end
* In the eCommerce, for products with equal website_sequence
Simon Lejeune [Tue, 9 Sep 2014 12:36:00 +0000 (14:36 +0200)]
[FIX] Report: search associated qweb views: do not forward context
The context may be inconsistent (for instance, containing a group_by associated to another
model). The client will take care of keeping it consistent. Fixes issue #1768
rsi-odoo [Tue, 9 Sep 2014 05:49:43 +0000 (11:19 +0530)]
[IMP] product : Improve tooltip of pricelist on min_quantity field.
Denis Ledoux [Tue, 9 Sep 2014 11:30:07 +0000 (13:30 +0200)]
[FIX] web_calendar: calendar title and column according to l10n
Christophe Simonis [Tue, 9 Sep 2014 11:26:51 +0000 (13:26 +0200)]
[FIX] fields.py: One2many fields only set inverse field on Many2one fields
Christophe Simonis [Tue, 9 Sep 2014 11:09:50 +0000 (13:09 +0200)]
[FIX] base: ir.model.data.name_get() respect expected behavior.
name_get() must return a value for each ids and keep order of ids.
Raphael Collet [Tue, 9 Sep 2014 09:42:50 +0000 (11:42 +0200)]
[FIX] account.invoice.line: move context to last position in onchange methods
The methods product_id_change() and uos_id_change() have been converted to the
new api, and now use the decorator @multi. When invoked with the old api, by
convention the methods will take the last argument as the context. But this
will not work properly for those methods, as the context is passed in another
position. In order to avoid an argument swap in the api wrapper, we moved the
context to its expected position.
Fixes #1943
Olivier Dony [Tue, 9 Sep 2014 08:35:38 +0000 (10:35 +0200)]
[IMP] auth_crypt: auto-install, improve description, bump version
The compatibility issue with auth_ldap has been
fixed and the default key derivation function
switched to PKDF2+SHA512. `auth_signup` provides
a password reset mechanism that can be used in
combination with `auth_crypt`.
rolvraen [Fri, 18 Jul 2014 21:57:30 +0000 (23:57 +0200)]
[ADD] l10n_no: Add Norwegian chart of accounts
Fixes #1272
Raphael Collet [Tue, 9 Sep 2014 08:12:00 +0000 (10:12 +0200)]
[IMP] doc/backend: add example using jsonrpclib
Raphael Collet [Tue, 9 Sep 2014 08:11:33 +0000 (10:11 +0200)]
[IMP] openerp/http.py: accept mimetype application/json-rpc for json-rpc calls
Xavier Morel [Fri, 5 Sep 2014 14:04:02 +0000 (16:04 +0200)]
[ADD] doc: model inheritance stuff
Olivier Dony [Mon, 8 Sep 2014 15:43:49 +0000 (17:43 +0200)]
[I18N] Update 8.0 translations with latest changes from Launchpad
Simon Lejeune [Mon, 8 Sep 2014 17:00:05 +0000 (19:00 +0200)]
[FIX] web: base.css: fixed width for input of file type under oe_avatar
Browsers add different width to input of file type, messing up the usability of the
product formview placing a 'phantom' box in front of the options. Added a specific
css rule for this case.
Denis Ledoux [Mon, 8 Sep 2014 16:21:20 +0000 (18:21 +0200)]
[FIX] web: failing onchanges should not prevent to save
This patch is related to
82adba4714d9b809aad835d0d77e6b6f9fde8ddc
With the above patch, it wasn't possible anymore to save if an onchange failed. This isn't the expected behavior.
Besides, $.when.apply($, defs) is rejected as soon as one def fails, without waiting other defs to be either resolved or rejected.
This new patch allows to save if onchange fails, and wait for onchanges sequentially.
Frederic van der Essen [Mon, 8 Sep 2014 15:49:10 +0000 (17:49 +0200)]
[FIX] point_of_sale: flush orders before closing the pos. This will help prevent users from closing the session with unflushed orders
Frederic van der Essen [Mon, 8 Sep 2014 15:03:21 +0000 (17:03 +0200)]
[FIX] point_of_sale: activate on screen keyboard for user search
Frederic van der Essen [Mon, 8 Sep 2014 10:49:34 +0000 (12:49 +0200)]
[FIX] point_of_sale: prevent inexact payements when there is no cash payment method available as it will crash the backend
Frederic van der Essen [Mon, 8 Sep 2014 10:33:37 +0000 (12:33 +0200)]
[FIX] point_of_sale: the self_checkout related fields are obsolete and should be removed, but we are too late in the release schedule to do so. Marking them as FIXME, to be removed for next major version
Frederic van der Essen [Wed, 3 Sep 2014 12:28:17 +0000 (14:28 +0200)]
[WIP] point_of_sale: checking for consistency between the user and the session's company
Frederic van der Essen [Tue, 2 Sep 2014 15:35:01 +0000 (17:35 +0200)]
[WIP] point_of_sale: refactor error popups in preparation of a multicompany-screwup prevention error popup
Raphael Collet [Mon, 8 Sep 2014 15:16:10 +0000 (17:16 +0200)]
[IMP] doc/backend: add example for JSON-RPC interaction
Olivier Dony [Mon, 8 Sep 2014 14:53:11 +0000 (16:53 +0200)]
[MERGE] Forward-port of saas-5 up to 9ce08b7
Olivier Dony [Wed, 3 Sep 2014 16:44:22 +0000 (18:44 +0200)]
[FIX] ir.qweb: consider empty cached bundle as a cache miss
Sometimes a cached bundled could be missing in the
ir.attachment filestore (for example after copying
a database for test purposes without duplicating
the filestore as well).
When this happens ir.attachment will return an empty
file contents ; treat this as a cache miss.
This means empty bundles would not be cached, which
is not a big issue - there is little benefit in
caching them, and they should not be common nor
useful.
Olivier Dony [Wed, 3 Sep 2014 16:39:25 +0000 (18:39 +0200)]
[FIX] ir.attachment: less non-transactional side-effects during deletion
When deleting filesystem-backed attachements, the
deletion on the file-system is not transactional.
In the event of a transaction rollback, the file
deletion would not be rolled back, which is a
dangerous side-effect.
This can happen for example when several transactions
try to delete the same file(s) at the same time.
The duplicate deletions might be detected by the
database (being concurrent update errors), and rolled
back at the point of the DELETE query, to be retried.
If the files have already been deleted in the file
system it before the rollback, it leaves the system
in an inconsistent state, at least temporarily.
One case where we have seen it is when web bundles
are loaded by many web users at the same time, right
after being updated (and thus invalidated).
As they are currently cached as ir.attachment records,
this often causes a corruption of the cache.
Olivier Dony [Wed, 3 Sep 2014 15:08:30 +0000 (17:08 +0200)]
[IMP] ir.attachment: include traceback when logging low-level filesystem errors
Simon Lejeune [Mon, 8 Sep 2014 12:08:40 +0000 (14:08 +0200)]
[FIX] Calendar: fix some display issues
* render the invitation widget inside oe_application
* override the margin of oe_right in order to display the two div on the same line
Simon Lejeune [Mon, 8 Sep 2014 12:00:42 +0000 (14:00 +0200)]
[FIX] web: webclient_bootstrap: render the menus when the user is really a user
The webclient rendering is done in two parts: the server renders the boilerplates
including the menus, and then the javascript launch the webclient using the
server-side boilerplates. In some case, we want to render the boilerplates but not
the menus (auth_calendar). Added groups around the t-call to the menu in the web
template. Fixes issue #2044.
Niels Huylebroeck [Fri, 5 Sep 2014 11:59:48 +0000 (13:59 +0200)]
[FIX] stock_account: Preserve action_done return value
stock_account module override the action_done method of stock.move but does not return the same value
This causes problems when calling this function from xmlrpc because the resulting value is now None and that is not allowed to be marshaled by default.
Xavier Morel [Mon, 8 Sep 2014 09:14:44 +0000 (11:14 +0200)]
[IMP] distribute branding on @groups instead of disabling edition
Avoids 2 rendering passes, and allows editing e.g. events detail page, which
couldn't be done (due to groups=public in a mail component)
fixes #1994
Christophe Simonis [Fri, 5 Sep 2014 15:22:56 +0000 (17:22 +0200)]
[REVERT] 2 previous commits (f3333f9 and 6e5b09a)
David Monjoie [Fri, 5 Sep 2014 15:12:49 +0000 (17:12 +0200)]
[FIX] removed bad comments from previous commit
David Monjoie [Fri, 5 Sep 2014 15:09:12 +0000 (17:09 +0200)]
[ADD] website_sale_digital
Fabien Meghazi [Thu, 4 Sep 2014 14:31:30 +0000 (16:31 +0200)]
[FIX] Restore /login redirection on SessionExpired
The feature was broken due to an incompatibility
when forward porting 624f256 and a78e27f
Denis Ledoux [Fri, 5 Sep 2014 13:59:07 +0000 (15:59 +0200)]
[FIX] point_of_sale: field type on bank statement line no longer exists
Jeremy Kersten [Fri, 5 Sep 2014 13:18:07 +0000 (15:18 +0200)]
[IMP] base: Odoo-ification and bootstrapification from the "About Us" popup
Jeremy Kersten [Fri, 5 Sep 2014 12:51:08 +0000 (14:51 +0200)]
[IMP] website: google analytic - use Automatic Cookie Domain Configuration.
Automatic Cookie Domain Configuration simplifies cross domain tracking implementations by automatically writing cookies to the highest level domain possible when the auto parameter is used. When used on the domain www.example.co.uk, it will try to write cookies in the following order:
co.uk
example.co.uk
www.example.co.uk
Analytics.js will fail to write a cookie on co.uk but will succeed on example.co.uk. Since a cookie was succesfully written on a higher level domain, www.example.co.uk will be skipped.
Fabien Meghazi [Tue, 5 Aug 2014 12:13:01 +0000 (14:13 +0200)]
[FIX] Some fixes for base_import_module
- Properly check unmet dependencies
- Set imported module's state to 'installed'
- Fix bad translation usage
Christophe Simonis [Thu, 4 Sep 2014 16:03:24 +0000 (18:03 +0200)]
[MERGE] forward port of branch saas-5 up to 9363bc9
Denis Ledoux [Thu, 4 Sep 2014 15:55:48 +0000 (17:55 +0200)]
[FIX] website_quote: onchange return nothing if product is False
Christophe Simonis [Thu, 4 Sep 2014 15:51:42 +0000 (17:51 +0200)]
[MERGE] forward port of branch saas-3 up to 3d80dc2
Christophe Simonis [Thu, 4 Sep 2014 15:46:51 +0000 (17:46 +0200)]
[MERGE] forward port of branch 7.0 up to 59b76ee
Your Name [Thu, 21 Aug 2014 12:55:49 +0000 (18:25 +0530)]
[FIX] sale: keep page when confirming a sale order
To keep the pager and view changer after confirmation of a sale order, do not reload the view (quotation and sale order view are the same anyway)
Fixes #250
Denis Ledoux [Thu, 4 Sep 2014 15:21:12 +0000 (17:21 +0200)]
[FIX] web: wait onchanges to be processed before save
Christophe Simonis [Wed, 3 Sep 2014 18:05:37 +0000 (20:05 +0200)]
FIX] packaging: odoo-ification
Xavier Morel [Thu, 4 Sep 2014 14:23:15 +0000 (16:23 +0200)]
[IMP] doc: move version switcher to header
as recommended by nwi
use same style as logo but very slightly smaller font, otherwise the
difference is a bit jarring as numbers are much bigger than the app logo's
text
Raphael Collet [Tue, 2 Sep 2014 08:50:52 +0000 (10:50 +0200)]
[IMP] models: inherited fields are related fields read as the current user
Add an attribute 'related_sudo' (True by default) for related fields.
A related field is computed as superuser if related_sudo is True.
Add explicit related fields 'name' and 'email' on 'res.users', as these should
be readable by the public user with module website_forum.
Raphael Collet [Fri, 22 Aug 2014 14:14:58 +0000 (16:14 +0200)]
[IMP] models: "X in self" is now equivalent to any(X == rec for rec in self)
Fix modules with code like "record.id in other.stuff_ids".
Raphael Collet [Thu, 4 Sep 2014 12:59:45 +0000 (14:59 +0200)]
[FIX] base: remove test_ir_model, which causes bugs
The test in test_ir_model creates a custom model. This causes a full reload of
the registry, which recursively installs the required modules while 'base' is
being tested. As a side effect, it commits stuff from the database, so that
the effects of test_ir_model are actually not rolled back.
Somesh Khare [Tue, 26 Aug 2014 06:25:23 +0000 (11:55 +0530)]
[FIX] document: display Attachment(s) menu only on form view
The attachment menu (list and add) has no effect in tree view (not supporting multi-items upload and display), the menu should then only be displayed in these view (opw 612534)
Xavier Morel [Thu, 4 Sep 2014 12:40:20 +0000 (14:40 +0200)]
[ADD] support for a version switcher in odoo theme thing
needs beauty input
Xavier Morel [Thu, 4 Sep 2014 09:08:54 +0000 (11:08 +0200)]
[ADD] doc's readme
* also only enable linkcode if Sphinx >= 1.2
* fix html inline roles?
Jérome Maes [Thu, 4 Sep 2014 12:26:07 +0000 (14:26 +0200)]
[FIX] im_chat : enable chat widget only for base.group_user
Christophe Matthieu [Thu, 4 Sep 2014 11:08:42 +0000 (13:08 +0200)]
[FIX] website_sale: customer write on public user and the sale order is apply to public user if the public user is active=True; the checkout layout display state_id field twice
Denis Ledoux [Thu, 4 Sep 2014 10:31:14 +0000 (12:31 +0200)]
[MERGE] forward port of branch 7.0 up to 5872c24
Denis Ledoux [Thu, 4 Sep 2014 10:28:16 +0000 (12:28 +0200)]
[FIX] stock: on partial picking, do no open a new window action if not needed
This is related to rev. dd4d72d
Not opening a new window action allows to keep the current list of stock picking being threated, and to use the next an previous arrow of the forom view of the web client.
Géry Debongnie [Thu, 4 Sep 2014 10:11:40 +0000 (12:11 +0200)]
[FIX] correct css computation to remove unnecessary toolbar
qdp-odoo [Thu, 4 Sep 2014 09:32:16 +0000 (11:32 +0200)]
[FIX] account: several fixes on the new bank statement reconciliation widget
Denis Ledoux [Thu, 4 Sep 2014 09:15:13 +0000 (11:15 +0200)]
[FIX] account: invoiced button values must be calculated as the user
Otherwise, if done with the superuser:
- The multi-company rules won't work, the user will have the amount of all invoices, cross-companies
- The amount currency will always be the currency of the superuser
Josse Colpaert [Thu, 4 Sep 2014 08:32:48 +0000 (10:32 +0200)]
Merge pull request #2178 from odoo-dev/8.0-wmsmultiop-jco
[IMP] Courtesy of kevin3274 issue 1258: orderpoint should have float mul...
Raphael Collet [Wed, 3 Sep 2014 12:33:14 +0000 (14:33 +0200)]
[FIX] openerp.api.Environment: move recomputation todos into a shared object
This fixes a bug which is usually triggered in module account_followup, but
does not occur deterministically. Some recomputations of computed fields are
apparently missing. Environment objects containing recomputations todos and
kept alive by a WeakSet, are removed by the Python garbage collector before
recomputation takes place. We fix the bug by moving the recomputation todos in
a non-weakref'ed object.
Martin Trigaux [Thu, 4 Sep 2014 08:17:18 +0000 (10:17 +0200)]
[IMP] crm_partner_assign: remove inexistant onchange
This field is readonly so a onchange is useless anyway (opw 612593)
xmo-odoo [Thu, 4 Sep 2014 07:38:23 +0000 (09:38 +0200)]
Merge pull request #2173 from pedrobaeza/8.0-module_icon_field_size
[FIX] Size for icon field of ir_module_module table in base.sql
fixes #2095
Pedro M. Baeza [Wed, 3 Sep 2014 23:46:44 +0000 (01:46 +0200)]
[FIX] Size for icon field of ir_module_module table in base.sql
Josse Colpaert [Wed, 3 Sep 2014 20:25:00 +0000 (22:25 +0200)]
[IMP] Courtesy of kevin3274 issue 1258: orderpoint should have float multiple instead of integer