From: Vo Minh Thu <vmt@openerp.com>
Date: Wed, 20 Feb 2013 10:22:59 +0000 (+0100)
Subject: [IMP] safe_eval: do not log exceptions, when re-raising a new exception, make the... 
X-Git-Tag: InsPy_master01~1492^2~2
X-Git-Url: http://git.inspyration.org/?a=commitdiff_plain;h=0de24bf983bbed6bcf544571bbdfef6d6ff802b0;p=odoo%2Fodoo.git

[IMP] safe_eval: do not log exceptions, when re-raising a new exception, make the stacktrace complete.

bzr revid: vmt@openerp.com-20130220102259-avee8fx2a1kpdog3
---

diff --git a/openerp/tools/safe_eval.py b/openerp/tools/safe_eval.py
index b99de38..c56c94e 100644
--- a/openerp/tools/safe_eval.py
+++ b/openerp/tools/safe_eval.py
@@ -106,11 +106,11 @@ def test_expr(expr, allowed_codes, mode="eval"):
             expr = expr.strip()
         code_obj = compile(expr, "", mode)
     except (SyntaxError, TypeError):
-        _logger.debug('Invalid eval expression', exc_info=True)
         raise
-    except Exception:
-        _logger.debug('Disallowed or invalid eval expression', exc_info=True)
-        raise ValueError("%s is not a valid expression" % expr)
+    except Exception, e:
+        import sys
+        exc_info = sys.exc_info()
+        raise ValueError, '"%s" while compiling\n%s' % (str(e), expr), exc_info[2]
     for code in _get_opcodes(code_obj):
         if code not in allowed_codes:
             raise ValueError("opcode %s not allowed (%r)" % (opname[code], expr))
@@ -237,10 +237,7 @@ def safe_eval(expr, globals_dict=None, locals_dict=None, mode="eval", nocopy=Fal
                 'set' : set
             }
     )
-    try:
-        return eval(test_expr(expr, _SAFE_OPCODES, mode=mode), globals_dict, locals_dict)
-    except Exception:
-        _logger.exception('Cannot eval %r', expr)
-        raise
+    c = test_expr(expr, _SAFE_OPCODES, mode=mode)
+    return eval(c, globals_dict, locals_dict)
 
 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4: