base module quality
authormra (Open ERP) <mra@tinyerp.com>
Mon, 29 Dec 2008 05:40:49 +0000 (11:10 +0530)
committermra (Open ERP) <mra@tinyerp.com>
Mon, 29 Dec 2008 05:40:49 +0000 (11:10 +0530)
bzr revid: mra@tinyerp.com-20081229054049-ht4jqvwjt8047plb

addons/base_module_quality/base_module_quality.py
addons/base_module_quality/method_test/method_test.py
addons/base_module_quality/pylint_test/pylint_test.py
addons/base_module_quality/speed_test/speed_test.py
addons/base_module_quality/wizard/module_quality_check.py

index 101043b..78e2b90 100644 (file)
@@ -100,10 +100,10 @@ class abstract_quality_check(object):
             detail = ""
             detail += "\n===Method Test===\n"
             detail += ('{| border="1" cellspacing="0" cellpadding="5" align="left" \n! %-40s \n! %-16s \n! %-20s \n! %-16s ') % (header[0].ljust(40), header[1].ljust(16), header[2].ljust(20), header[3].ljust(16))
-            for res in data_list[1][0]:
-                detail += ('\n|-\n| %s \n| %s \n| %s \n| %s ') % (res, data_list[1][0][res][0], data_list[1][0][res][1], data_list[1][0][res][2])
-            res_format['summary'] = [data_list[0][0]]
-            res_format['detail'] = [detail + '\n|}']
+            for res in data_list[1]:
+                detail += ('\n|-\n| %s \n| %s \n| %s \n| %s ') % (res, data_list[1][res][0], data_list[1][res][1], data_list[1][res][2])
+            res_format['summary'] = data_list[0]
+            res_format['detail'] = detail + '\n|}'
         elif test=='pylint':
             res_format['summary'] = data_list[0]
             res_format['detail'] = data_list[1]
@@ -114,7 +114,7 @@ class abstract_quality_check(object):
             for data in data_list[1]:
                 detail +=  ('\n|-\n| %s \n| %s \n| %s \n| %s \n| %s \n| %s ') % (data[0], data[1], data[2], data[3], data[4], data[5])
             res_format['summary'] = data_list[0]
-            res_format['detail'] = [detail  + '\n|}\n']
+            res_format['detail'] = detail  + '\n|}\n'
         return res_format
 
 
index b201572..09dbdb3 100644 (file)
@@ -82,7 +82,7 @@ class quality_test(base_module_quality.abstract_quality_check):
 This test checks if the module classes are raising exception when calling basic methods or no.
 
 """ + "Score: " + str(self.score) + "/10\n"
-        self.result = self.format_table(test='method', header=header_list, data_list=[[summary],[result]])
+        self.result = self.format_table(test='method', header=header_list, data_list=[summary,result])
         return None
 
 
index 5bf2403..d448cf1 100644 (file)
@@ -81,7 +81,7 @@ class quality_test(base_module_quality.abstract_quality_check):
     This test checks if the module satisfy the current coding standard used by OpenERP.
 
 """ + "Score: " + str(self.score) + "/10\n"
-        self.result = self.format_table(test='pylint', data_list=[[summary],[detail]])
+        self.result = self.format_table(test='pylint', data_list=[summary,detail])
         return None
 
 
index 5a9176e..5200bd2 100644 (file)
@@ -102,7 +102,7 @@ class quality_test(base_module_quality.abstract_quality_check):
     This test checks the speed of the module.
 
 """+ "Score: " + str(self.score) + "/10\n"
-        self.result = self.format_table(test='speed', header=header_list, data_list=[[summary],list1])
+        self.result = self.format_table(test='speed', header=header_list, data_list=[summary,list1])
         return None
 
 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
index 48a04f8..cda3a92 100644 (file)
@@ -81,8 +81,8 @@ class wiz_quality_check(osv.osv_memory):
                     val.run_test(cr, uid, str(module_path))
                 else:
                     val.result += "The module has to be installed before running this test."
-                string_ret += val.result['summary'][0]
-                string_detail += val.result['detail'][0]
+                string_ret += val.result['summary']
+                string_detail += val.result['detail']
         self.string_detail = string_detail
         return string_ret