[IMP]if-else replace with switch case

bzr revid: vme@tinyerp.com-20111012122530-prscg6end1y00sh8

diff --git a/addons/web/static/src/js/view_editor.js b/addons/web/static/src/js/view_editor.js
index 2881a9a..d424700 100644 (file)
--- a/addons/web/static/src/js/view_editor.js
+++ b/addons/web/static/src/js/view_editor.js
@@ -198,38 +198,38 @@ openerp.web.ViewEditor =   openerp.web.Widget.extend({
         if(xpath_object.length!=0){
             var check = check_list[0];
             var obj;
-            if(check.length == 2){
-                if(parseInt(check[1])){
-                    var list_1 = _.select(val,function(element){
+            switch (check.length) {
+                case 2:
+                    if(parseInt(check[1])){
+                        var list_1 = _.select(val,function(element){
+                            var main_list = _.flatten(element.att_list);
+                            return _.include(main_list, check[0]);
+                        });
+                        obj = val[_.indexOf(val,list_1[parseInt(check[1])-1])];
+                    } else {
+                        obj = _.detect(val, function(element){
+                            var main_list = _.flatten(element.att_list);
+                            return _.include(main_list, check[0]);
+                        });
+                    }
+                    break;
+                case 3:
+                    obj = _.detect(val,function(element){
                         var main_list = _.flatten(element.att_list);
-                        return _.include(main_list, check[0]);
+                        check = _.uniq(check);
+                        var insert = _.intersection(main_list,check);
+                        if(insert.length == check.length ){return element;}
                     });
-                    obj = val[_.indexOf(val,list_1[parseInt(check[1])-1])];
-                } else {
-                    obj = _.detect(val, function(element){
+                    break;
+                case 1:
+                    var list_1 = _.select(val,function(element){
                         var main_list = _.flatten(element.att_list);
                         return _.include(main_list, check[0]);
                     });
-                }
-            }else if(check.length == 3){
-                obj = _.detect(val,function(element){
-                    var main_list = _.flatten(element.att_list);
-                    check = _.uniq(check);
-                    var insert = _.intersection(main_list,check);
-                    if(insert.length == check.length ){return element;}
-                });
-            }else{
-                var list_1 = _.select(val,function(element){
-                    var main_list = _.flatten(element.att_list);
-                    return _.include(main_list, check[0]);
-                });
-                if(list_1 != 0){
-                    if(check_list.length == 1){
-                        obj = list_1[0];
-                    }else{
-                        check_list.shift();
+                    if(list_1 != 0){
+                        (check_list.length == 1)? obj = list_1[0] : check_list.shift();
                     }
-                }
+                    break;
             }
             if(obj){
                 check_list.shift();