[FIX] res_users: side-effect of virtual groups prevented users from saving their...

lp bug: https://launchpad.net/bugs/904626 fixed

bzr revid: odo@openerp.com-20111215120741-1lne9fjs67d7c42k

diff --git a/openerp/addons/base/res/res_users.py b/openerp/addons/base/res/res_users.py
index 3a159d1..10a6565 100644 (file)
--- a/openerp/addons/base/res/res_users.py
+++ b/openerp/addons/base/res/res_users.py
@@ -828,8 +828,11 @@ class users_view(osv.osv):
                 selected = values.pop(f)
                 if selected:
                     add.append(selected)
-        # remove groups in 'remove' and add groups in 'add'
-        values['groups_id'] = [(3, id) for id in remove] + [(4, id) for id in add]
+        # update values *only* if groups are being modified, otherwise
+        # we introduce spurious changes that might break the super.write() call.
+        if add or remove:
+            # remove groups in 'remove' and add groups in 'add'
+            values['groups_id'] = [(3, id) for id in remove] + [(4, id) for id in add]
 
     def default_get(self, cr, uid, fields, context=None):
         group_fields, fields = partition(is_reified_group, fields)