[IMP] ir.attachment: include traceback when logging low-level filesystem errors
authorOlivier Dony <odo@openerp.com>
Wed, 3 Sep 2014 15:08:30 +0000 (17:08 +0200)
committerOlivier Dony <odo@openerp.com>
Mon, 8 Sep 2014 14:52:41 +0000 (16:52 +0200)
openerp/addons/base/ir/ir_attachment.py

index de768d2..c636463 100644 (file)
@@ -123,7 +123,7 @@ class ir_attachment(osv.osv):
             else:
                 r = open(full_path,'rb').read().encode('base64')
         except IOError:
-            _logger.error("_read_file reading %s",full_path)
+            _logger.exception("_read_file reading %s", full_path)
         return r
 
     def _file_write(self, cr, uid, value):
@@ -134,7 +134,7 @@ class ir_attachment(osv.osv):
                 with open(full_path, 'wb') as fp:
                     fp.write(bin_value)
             except IOError:
-                _logger.error("_file_write writing %s", full_path)
+                _logger.exception("_file_write writing %s", full_path)
         return fname
 
     def _file_delete(self, cr, uid, fname):
@@ -144,10 +144,10 @@ class ir_attachment(osv.osv):
             try:
                 os.unlink(full_path)
             except OSError:
-                _logger.error("_file_delete could not unlink %s",full_path)
+                _logger.exception("_file_delete could not unlink %s", full_path)
             except IOError:
                 # Harmless and needed for race conditions
-                _logger.error("_file_delete could not unlink %s",full_path)
+                _logger.exception("_file_delete could not unlink %s", full_path)
 
     def _data_get(self, cr, uid, ids, name, arg, context=None):
         if context is None: