[FIX] debian logfile rotation and init cleanup, courtesy of Hiren

bzr revid: al@openerp.com-20130320231828-hhw7o17ahvl0cv7b

diff --git a/debian/openerp.init b/debian/openerp.init
index 6abb6f1..98e6532 100644 (file)
--- a/debian/openerp.init
+++ b/debian/openerp.init
@@ -17,55 +17,46 @@ DAEMON=/usr/bin/openerp-server
 NAME=openerp-server
 DESC=openerp-server
 CONFIG=/etc/openerp/openerp-server.conf
-LOGFILE=/var/log/openerp-server.log
+LOGFILE=/var/log/openerp/openerp-server.log
 USER=openerp
 
 test -x ${DAEMON} || exit 0
 
 set -e
 
-case "${1}" in
-       start)
-               echo -n "Starting ${DESC}: "
-
-               start-stop-daemon --start --quiet --pidfile /var/run/${NAME}.pid \
-                       --chuid ${USER} --background --make-pidfile \
-                       --exec ${DAEMON} -- --config=${CONFIG} \
-                           --logfile=${LOGFILE}
-
-               echo "${NAME}."
-               ;;
-
-       stop)
-               echo -n "Stopping ${DESC}: "
-
-               start-stop-daemon --stop --quiet --pidfile /var/run/${NAME}.pid \
-                       --oknodo
-
-               echo "${NAME}."
-               ;;
+do_start () {
+    echo -n "Starting ${DESC}: "
+    start-stop-daemon --start --quiet --pidfile /var/run/${NAME}.pid --chuid ${USER} --background --make-pidfile --exec ${DAEMON} -- --config=${CONFIG} --logfile=${LOGFILE}
+    echo "${NAME}."
+}
 
-       restart|force-reload)
-               echo -n "Restarting ${DESC}: "
+do_stop () {
+    echo -n "Stopping ${DESC}: "
+    start-stop-daemon --stop --quiet --pidfile /var/run/${NAME}.pid --oknodo
+    echo "${NAME}."
+}
 
-               start-stop-daemon --stop --quiet --pidfile /var/run/${NAME}.pid \
-                       --oknodo
-
-               sleep 1
-
-               start-stop-daemon --start --quiet --pidfile /var/run/${NAME}.pid \
-                       --chuid ${USER} --background --make-pidfile \
-                       --exec ${DAEMON} -- --config=${CONFIG} \
-                           --logfile=${LOGFILE}
-
-               echo "${NAME}."
-               ;;
-
-       *)
-               N=/etc/init.d/${NAME}
-               echo "Usage: ${NAME} {start|stop|restart|force-reload}" >&2
-               exit 1
-               ;;
+case "${1}" in
+    start)
+        do_start
+        ;;
+
+    stop)
+        do_stop
+        ;;
+
+    restart|force-reload)
+        echo -n "Restarting ${DESC}: "
+        do_stop
+        sleep 1
+        do_start
+        ;;
+
+    *)
+        N=/etc/init.d/${NAME}
+        echo "Usage: ${NAME} {start|stop|restart|force-reload}" >&2
+        exit 1
+        ;;
 esac
 
 exit 0

diff --git a/debian/openerp.postinst b/debian/openerp.postinst
index 8700a25..2eccd51 100644 (file)
--- a/debian/openerp.postinst
+++ b/debian/openerp.postinst
@@ -12,9 +12,9 @@ case "${1}" in
         chown openerp:openerp /etc/openerp/openerp-server.conf
         chmod 0640 /etc/openerp/openerp-server.conf
         # Creating log file
-        touch /var/log/openerp-server.log
-        chown openerp:openerp /var/log/openerp-server.log
-        chmod 0640 /var/log/openerp-server.log
+        mkdir -p /var/log/openerp/
+        chown openerp:openerp /var/log/openerp
+        chmod 0750 /var/log/openerp
         # Creating local storage directory
         mkdir -p /var/lib/openerp/filestore
         chown openerp:openerp -R /var/lib/openerp