[REVIEW] Some cleaning after review and before merging.

bzr revid: tde@openerp.com-20120702161323-wvd0j6ng3dz56ifj

diff --git a/addons/mail/mail_thread.py b/addons/mail/mail_thread.py
index f69ccb3..5668709 100644 (file)
--- a/addons/mail/mail_thread.py
+++ b/addons/mail/mail_thread.py
@@ -584,7 +584,7 @@ class mail_thread(osv.Model):
                         # referenced thread was not found, we'll have to create a new one
                         res_id = False
         if not res_id:
-            res_id = int(create_record(msg))
+            res_id = create_record(msg)
         # To forward the email to other followers
         self.message_forward(cr, uid, model, [res_id], msg_txt, context=context)
         return res_id

diff --git a/addons/project/project.py b/addons/project/project.py
index f614d25..487daa8 100644 (file)
--- a/addons/project/project.py
+++ b/addons/project/project.py
@@ -1138,7 +1138,9 @@ class task(base_stage, osv.osv):
         return 'Task'
 
     def get_needaction_user_ids(self, cr, uid, ids, context=None):
-        """ Returns the user_ids that have to perform an action
+        """ Returns the user_ids that have to perform an action.
+            Add to the previous results given by super the document responsible
+            when in draft mode.
             :return: dict { record_id: [user_ids], }
         """
         result = super(task, self).get_needaction_user_ids(cr, uid, ids, context=context)

diff --git a/addons/project_issue/project_issue_demo.xml b/addons/project_issue/project_issue_demo.xml
index 9b7b5a6..b3fb458 100644 (file)
--- a/addons/project_issue/project_issue_demo.xml
+++ b/addons/project_issue/project_issue_demo.xml
@@ -227,7 +227,7 @@
         <field name="stage_id" ref="project.project_tt_specification"/>
     </record>
 
-    <!--        Call Function to set the leads as Unread -->
+    <!--        Call Function to set some issues as Unread -->
     <function model="project.issue" name="message_mark_as_unread"
         eval="[ ref('crm_case_improvereportsinhrms0'), ref('crm_case_createnewobject0')], {}"
     />

diff --git a/addons/purchase/purchase.py b/addons/purchase/purchase.py
index 7bb56d2..e74ca83 100644 (file)
--- a/addons/purchase/purchase.py
+++ b/addons/purchase/purchase.py
@@ -736,7 +736,7 @@ class purchase_order(osv.osv):
         result = super(purchase_order, self).get_needaction_user_ids(cr, uid, ids, context=context)
         for obj in self.browse(cr, uid, ids, context=context):
             if obj.state == 'approved':
-                result[obj.id] = [obj.validator.id]
+                result[obj.id].append(obj.validator.id)
         return result
     
     def create_send_note(self, cr, uid, ids, context=None):

diff --git a/addons/sale/sale.py b/addons/sale/sale.py
index d6c6cac..0a3ebbe 100644 (file)
--- a/addons/sale/sale.py
+++ b/addons/sale/sale.py
@@ -1025,7 +1025,7 @@ class sale_order(osv.osv):
         result = super(sale_order, self).get_needaction_user_ids(cr, uid, ids, context=context)
         for obj in self.browse(cr, uid, ids, context=context):
             if (obj.state == 'manual' or obj.state == 'progress'):
-                result[obj.id] = [obj.user_id.id]
+                result[obj.id].append(obj.user_id.id)
         return result
  
     def create_send_note(self, cr, uid, ids, context=None):