[FIX] links and threads
[odoo/odoo.git] / addons / website_forum / controllers / main.py
index d2f8662..3a1397e 100644 (file)
@@ -1,18 +1,17 @@
 # -*- coding: utf-8 -*-
 
-from datetime import datetime
 import werkzeug.urls
 import werkzeug.wrappers
 import simplejson
+import lxml
+from urllib2 import urlopen
 
 from openerp import tools
-from openerp import SUPERUSER_ID
 from openerp.addons.web import http
 from openerp.addons.web.controllers.main import login_redirect
 from openerp.addons.web.http import request
 from openerp.addons.website.controllers.main import Website as controllers
 from openerp.addons.website.models.website import slug
-from openerp.tools import html2plaintext
 
 controllers = controllers()
 
@@ -22,68 +21,76 @@ class WebsiteForum(http.Controller):
     _user_per_page = 30
 
     def _get_notifications(self):
-        cr, uid, context = request.cr, request.uid, request.context
-        Message = request.registry['mail.message']
-        badge_st_id = request.registry['ir.model.data'].xmlid_to_res_id(cr, uid, 'gamification.mt_badge_granted')
-        if badge_st_id:
-            msg_ids = Message.search(cr, uid, [('subtype_id', '=', badge_st_id), ('to_read', '=', True)], context=context)
-            msg = Message.browse(cr, uid, msg_ids, context=context)
+        badge_subtype = request.env.ref('gamification.mt_badge_granted')
+        if badge_subtype:
+            msg = request.env['mail.message'].search([('subtype_id', '=', badge_subtype.id), ('to_read', '=', True)])
         else:
             msg = list()
         return msg
 
     def _prepare_forum_values(self, forum=None, **kwargs):
-        Forum = request.registry['forum.forum']
-        user = request.registry['res.users'].browse(request.cr, request.uid, request.uid, context=request.context)
-        values = {'user': user,
-                  'is_public_user': user.id == request.website.user_id.id,
-                  'notifications': self._get_notifications(),
-                  'header': kwargs.get('header', dict()),
-                  'searches': kwargs.get('searches', dict()),
-                  'can_edit_own': True,
-                  'can_edit_all': user.karma > Forum._karma_modo_edit_all,
-                  'can_close_own': user.karma > Forum._karma_modo_close_own,
-                  'can_close_all': user.karma > Forum._karma_modo_close_all,
-                  'can_unlink_own': user.karma > Forum._karma_modo_unlink_own,
-                  'can_unlink_all': user.karma > Forum._karma_modo_unlink_all,
-                  'can_unlink_comment': user.karma > Forum._karma_modo_unlink_comment,
-                  }
+        values = {
+            'user': request.env.user,
+            'is_public_user': request.env.user.id == request.website.user_id.id,
+            'notifications': self._get_notifications(),
+            'header': kwargs.get('header', dict()),
+            'searches': kwargs.get('searches', dict()),
+            'no_introduction_message': request.httprequest.cookies.get('no_introduction_message', False),
+            'validation_email_sent': request.session.get('validation_email_sent', False),
+            'validation_email_done': request.session.get('validation_email_done', False),
+        }
         if forum:
             values['forum'] = forum
         elif kwargs.get('forum_id'):
-            values['forum'] = request.registry['forum.forum'].browse(request.cr, request.uid, kwargs.pop('forum_id'), context=request.context)
+            values['forum'] = request.env['forum.forum'].browse(kwargs.pop('forum_id'))
         values.update(kwargs)
         return values
 
-    def _has_enough_karma(self, karma_name, uid=None):
-        Forum = request.registry['forum.forum']
-        karma = hasattr(Forum, karma_name) and getattr(Forum, karma_name) or 0
-        user = request.registry['res.users'].browse(request.cr, SUPERUSER_ID, uid or request.uid, context=request.context)
-        if user.karma < karma:
-            return False, {'error': 'not_enough_karma', 'karma': karma}
-        return True, {}
+    # User and validation
+    # --------------------------------------------------
+
+    @http.route('/forum/send_validation_email', type='json', auth='user', website=True)
+    def send_validation_email(self, forum_id=None, **kwargs):
+        if request.env.uid != request.website.user_id.id:
+            request.env.user.send_forum_validation_email(forum_id=forum_id)
+        request.session['validation_email_sent'] = True
+        return True
+
+    @http.route('/forum/validate_email', type='http', auth='public', website=True)
+    def validate_email(self, token, id, email, forum_id=None, **kwargs):
+        if forum_id:
+            try:
+                forum_id = int(forum_id)
+            except ValueError:
+                forum_id = None
+        done = request.env['res.users'].sudo().browse(int(id)).process_forum_validation_token(token, email, forum_id=forum_id)[0]
+        if done:
+            request.session['validation_email_done'] = True
+        if forum_id:
+            return request.redirect("/forum/%s" % int(forum_id))
+        return request.redirect('/forum')
+
+    @http.route('/forum/validate_email/close', type='json', auth='public', website=True)
+    def validate_email_done(self):
+        request.session['validation_email_done'] = False
+        return True
 
     # Forum
     # --------------------------------------------------
 
     @http.route(['/forum'], type='http', auth="public", website=True)
     def forum(self, **kwargs):
-        cr, uid, context = request.cr, request.uid, request.context
-        Forum = request.registry['forum.forum']
-        obj_ids = Forum.search(cr, uid, [], context=context)
-        forums = Forum.browse(cr, uid, obj_ids, context=context)
+        forums = request.env['forum.forum'].search([])
         return request.website.render("website_forum.forum_all", {'forums': forums})
 
     @http.route('/forum/new', type='http', auth="user", methods=['POST'], website=True)
     def forum_create(self, forum_name="New Forum", **kwargs):
-        forum_id = request.registry['forum.forum'].create(request.cr, request.uid, {
-            'name': forum_name,
-        }, context=request.context)
+        forum_id = request.env['forum.forum'].create({'name': forum_name})
         return request.redirect("/forum/%s" % slug(forum_id))
 
     @http.route('/forum/notification_read', type='json', auth="user", methods=['POST'], website=True)
     def notification_read(self, **kwargs):
-        request.registry['mail.message'].set_message_read(request.cr, request.uid, [int(kwargs.get('notification_id'))], read=True, context=request.context)
+        request.env['mail.message'].browse([int(kwargs.get('notification_id'))]).set_message_read(read=True)
         return True
 
     @http.route(['/forum/<model("forum.forum"):forum>',
@@ -91,10 +98,8 @@ class WebsiteForum(http.Controller):
                  '''/forum/<model("forum.forum"):forum>/tag/<model("forum.tag", "[('forum_id','=',forum[0])]"):tag>/questions''',
                  '''/forum/<model("forum.forum"):forum>/tag/<model("forum.tag", "[('forum_id','=',forum[0])]"):tag>/questions/page/<int:page>''',
                  ], type='http', auth="public", website=True)
-    def questions(self, forum, tag=None, page=1, filters='all', sorting='date', search='', **post):
-        cr, uid, context = request.cr, request.uid, request.context
-        Post = request.registry['forum.post']
-        user = request.registry['res.users'].browse(cr, uid, uid, context=context)
+    def questions(self, forum, tag=None, page=1, filters='all', sorting=None, search='', post_type=None, **post):
+        Post = request.env['forum.post']
 
         domain = [('forum_id', '=', forum.id), ('parent_id', '=', False), ('state', '=', 'active')]
         if search:
@@ -104,39 +109,32 @@ class WebsiteForum(http.Controller):
         if filters == 'unanswered':
             domain += [('child_ids', '=', False)]
         elif filters == 'followed':
-            domain += [('message_follower_ids', '=', user.partner_id.id)]
-        else:
-            filters = 'all'
-
-        if sorting == 'answered':
-            order = 'child_count desc'
-        elif sorting == 'vote':
-            order = 'vote_count desc'
-        elif sorting == 'date':
-            order = 'write_date desc'
-        else:
-            sorting = 'creation'
-            order = 'create_date desc'
+            domain += [('message_follower_ids', '=', request.env.user.partner_id.id)]
+        if post_type:
+            domain += [('post_type', '=', post_type)]
+
+        if not sorting:
+            sorting = forum.default_order
+
+        question_count = Post.search_count(domain)
 
-        question_count = Post.search(cr, uid, domain, count=True, context=context)
         if tag:
-            url = "/forum/%s/%s/questions" % (slug(forum), slug(tag))
+            url = "/forum/%s/tag/%s/questions" % (slug(forum), slug(tag))
         else:
             url = "/forum/%s" % slug(forum)
 
-        url_args = {}
+        url_args = {
+            'sorting': sorting
+        }
         if search:
             url_args['search'] = search
         if filters:
             url_args['filters'] = filters
-        if sorting:
-            url_args['sorting'] = sorting
         pager = request.website.pager(url=url, total=question_count, page=page,
                                       step=self._post_per_page, scope=self._post_per_page,
                                       url_args=url_args)
 
-        obj_ids = Post.search(cr, uid, domain, limit=self._post_per_page, offset=pager['offset'], order=order, context=context)
-        question_ids = Post.browse(cr, uid, obj_ids, context=context)
+        question_ids = Post.search(domain, limit=self._post_per_page, offset=pager['offset'], order=sorting)
 
         values = self._prepare_forum_values(forum=forum, searches=post)
         values.update({
@@ -148,6 +146,7 @@ class WebsiteForum(http.Controller):
             'filters': filters,
             'sorting': sorting,
             'search': search,
+            'post_type': post_type,
         })
         return request.website.render("website_forum.forum_index", values)
 
@@ -157,17 +156,17 @@ class WebsiteForum(http.Controller):
         return request.website.render("website_forum.faq", values)
 
     @http.route('/forum/get_tags', type='http', auth="public", methods=['GET'], website=True)
-    def tag_read(self, **post):
-        tags = request.registry['forum.tag'].search_read(request.cr, request.uid, [], ['name'], context=request.context)
-        data = [tag['name'] for tag in tags]
+    def tag_read(self, q='', l=25, **post):
+        data = request.env['forum.tag'].search_read(
+            domain=[('name', '=ilike', (q or '') + "%")],
+            fields=['id', 'name'],
+            limit=int(l),
+        )
         return simplejson.dumps(data)
 
     @http.route(['/forum/<model("forum.forum"):forum>/tag'], type='http', auth="public", website=True)
     def tags(self, forum, page=1, **post):
-        cr, uid, context = request.cr, request.uid, request.context
-        Tag = request.registry['forum.tag']
-        obj_ids = Tag.search(cr, uid, [('forum_id', '=', forum.id), ('posts_count', '>', 0)], limit=None, order='posts_count DESC', context=context)
-        tags = Tag.browse(cr, uid, obj_ids, context=context)
+        tags = request.env['forum.tag'].search([('forum_id', '=', forum.id), ('posts_count', '>', 0)], limit=None, order='posts_count DESC')
         values = self._prepare_forum_values(forum=forum, searches={'tags': True}, **post)
         values.update({
             'tags': tags,
@@ -178,42 +177,18 @@ class WebsiteForum(http.Controller):
     # Questions
     # --------------------------------------------------
 
-    @http.route(['/forum/<model("forum.forum"):forum>/ask'], type='http', auth="public", website=True)
-    def question_ask(self, forum, **post):
-        if not request.session.uid:
-            return login_redirect()
-        values = self._prepare_forum_values(forum=forum, searches={},  header={'ask_hide': True})
-        return request.website.render("website_forum.ask_question", values)
+    @http.route('/forum/get_url_title', type='json', auth="user", methods=['POST'], website=True)
+    def get_url_title(self, **kwargs):
+        arch = lxml.html.parse(urlopen(kwargs.get('url')))
+        return arch.find(".//title").text
 
-    @http.route('/forum/<model("forum.forum"):forum>/question/new', type='http', auth="user", methods=['POST'], website=True)
-    def question_create(self, forum, **post):
-        cr, uid, context = request.cr, request.uid, request.context
-        Tag = request.registry['forum.tag']
-        question_tag_ids = []
-        if post.get('question_tags').strip('[]'):
-            tags = post.get('question_tags').strip('[]').replace('"', '').split(",")
-            for tag in tags:
-                tag_ids = Tag.search(cr, uid, [('name', '=', tag)], context=context)
-                if tag_ids:
-                    question_tag_ids.append((4, tag_ids[0]))
-                else:
-                    question_tag_ids.append((0, 0, {'name': tag, 'forum_id': forum.id}))
-
-        new_question_id = request.registry['forum.post'].create(
-            request.cr, request.uid, {
-                'forum_id': forum.id,
-                'name': post.get('question_name'),
-                'content': post.get('content'),
-                'tag_ids': question_tag_ids,
-            }, context=context)
-        return werkzeug.utils.redirect("/forum/%s/question/%s" % (slug(forum), new_question_id))
-
-    @http.route(['''/forum/<model("forum.forum"):forum>/question/<model("forum.post", "[('forum_id','=',forum[0])]"):question>'''], type='http', auth="public", website=True)
+    @http.route(['''/forum/<model("forum.forum"):forum>/question/<model("forum.post", "[('forum_id','=',forum[0]),('parent_id','=',False)]"):question>'''], type='http', auth="public", website=True)
     def question(self, forum, question, **post):
-        cr, uid, context = request.cr, request.uid, request.context
         # increment view counter
-        request.registry['forum.post'].set_viewed(cr, SUPERUSER_ID, [question.id], context=context)
-
+        question.sudo().set_viewed()
+        if question.parent_id:
+            redirect_url = "/forum/%s/question/%s" % (slug(forum), slug(question.parent_id))
+            return werkzeug.utils.redirect(redirect_url, 301)
         filters = 'question'
         values = self._prepare_forum_values(forum=forum, searches=post)
         values.update({
@@ -235,19 +210,12 @@ class WebsiteForum(http.Controller):
             favourite_ids = [(4, request.uid)]
         else:
             favourite_ids = [(3, request.uid)]
-        request.registry['forum.post'].write(request.cr, request.uid, [question.id], {'favourite_ids': favourite_ids}, context=request.context)
+        question.sudo().write({'favourite_ids': favourite_ids})
         return favourite
 
     @http.route('/forum/<model("forum.forum"):forum>/question/<model("forum.post"):question>/ask_for_close', type='http', auth="user", methods=['POST'], website=True)
     def question_ask_for_close(self, forum, question, **post):
-        check_res = self._has_enough_karma(question.create_uid.id == request.uid and '_karma_modo_close_own' or '_karma_modo_close_all')
-        if not check_res[0]:
-            return werkzeug.utils.redirect("/forum/%s" % slug(forum))
-
-        cr, uid, context = request.cr, request.uid, request.context
-        Reason = request.registry['forum.post.reason']
-        reason_ids = Reason.search(cr, uid, [], context=context)
-        reasons = Reason.browse(cr, uid, reason_ids, context)
+        reasons = request.env['forum.post.reason'].search([])
 
         values = self._prepare_forum_values(**post)
         values.update({
@@ -256,7 +224,7 @@ class WebsiteForum(http.Controller):
             'forum': forum,
             'reasons': reasons,
         })
-        return request.website.render("website_forum.close_question", values)
+        return request.website.render("website_forum.close_post", values)
 
     @http.route('/forum/<model("forum.forum"):forum>/question/<model("forum.post"):question>/edit_answer', type='http', auth="user", website=True)
     def question_edit_answer(self, forum, question, **kwargs):
@@ -268,115 +236,94 @@ class WebsiteForum(http.Controller):
 
     @http.route('/forum/<model("forum.forum"):forum>/question/<model("forum.post"):question>/close', type='http', auth="user", methods=['POST'], website=True)
     def question_close(self, forum, question, **post):
-        check_res = self._has_enough_karma(question.create_uid.id == request.uid and '_karma_modo_close_own' or '_karma_modo_close_all')
-        if not check_res[0]:
-            return werkzeug.utils.redirect("/forum/%s" % slug(forum))
-
-        request.registry['forum.post'].write(request.cr, request.uid, [question.id], {
-            'state': 'close',
-            'closed_uid': request.uid,
-            'closed_date': datetime.today().strftime(tools.DEFAULT_SERVER_DATETIME_FORMAT),
-            'closed_reason_id': int(post.get('reason_id', False)),
-        }, context=request.context)
+        question.close(reason_id=int(post.get('reason_id', False)))
         return werkzeug.utils.redirect("/forum/%s/question/%s" % (slug(forum), slug(question)))
 
     @http.route('/forum/<model("forum.forum"):forum>/question/<model("forum.post"):question>/reopen', type='http', auth="user", methods=['POST'], website=True)
     def question_reopen(self, forum, question, **kwarg):
-        check_res = self._has_enough_karma(question.create_uid.id == request.uid and '_karma_modo_close_own' or '_karma_modo_close_all')
-        if not check_res[0]:
-            return werkzeug.utils.redirect("/forum/%s" % slug(forum))
-
-        request.registry['forum.post'].write(request.cr, request.uid, [question.id], {'state': 'active'}, context=request.context)
+        question.reopen()
         return werkzeug.utils.redirect("/forum/%s/question/%s" % (slug(forum), slug(question)))
 
     @http.route('/forum/<model("forum.forum"):forum>/question/<model("forum.post"):question>/delete', type='http', auth="user", methods=['POST'], website=True)
     def question_delete(self, forum, question, **kwarg):
-        check_res = self._has_enough_karma(question.create_uid.id == request.uid and '_karma_modo_unlink_own' or '_karma_modo_unlink_all')
-        if not check_res[0]:
-            return werkzeug.utils.redirect("/forum/%s" % slug(forum))
-
-        request.registry['forum.post'].write(request.cr, request.uid, [question.id], {'active': False}, context=request.context)
+        question.active = False
         return werkzeug.utils.redirect("/forum/%s/question/%s" % (slug(forum), slug(question)))
 
     @http.route('/forum/<model("forum.forum"):forum>/question/<model("forum.post"):question>/undelete', type='http', auth="user", methods=['POST'], website=True)
     def question_undelete(self, forum, question, **kwarg):
-        check_res = self._has_enough_karma(question.create_uid.id == request.uid and '_karma_modo_unlink_own' or '_karma_modo_unlink_all')
-        if not check_res[0]:
-            return werkzeug.utils.redirect("/forum/%s" % slug(forum))
-
-        request.registry['forum.post'].write(request.cr, request.uid, [question.id], {'active': True}, context=request.context)
+        question.active = True
         return werkzeug.utils.redirect("/forum/%s/question/%s" % (slug(forum), slug(question)))
 
     # Post
     # --------------------------------------------------
-
-    @http.route('/forum/<model("forum.forum"):forum>/post/<model("forum.post"):post>/new', type='http', auth="public", methods=['POST'], website=True)
-    def post_new(self, forum, post, **kwargs):
+    @http.route(['/forum/<model("forum.forum"):forum>/ask'], type='http', auth="public", website=True)
+    def forum_post(self, forum, post_type=None, **post):
+        if not request.session.uid:
+            return login_redirect()
+        user = request.env.user
+        if not post_type in ['question', 'link', 'discussion']:  # fixme: make dynamic
+            return werkzeug.utils.redirect('/forum/%s' % slug(forum))
+        if not user.email or not tools.single_email_re.match(user.email):
+            return werkzeug.utils.redirect("/forum/%s/user/%s/edit?email_required=1" % (slug(forum), request.session.uid))
+        values = self._prepare_forum_values(forum=forum, searches={}, header={'ask_hide': True})
+        return request.website.render("website_forum.new_%s" % post_type, values)
+
+    @http.route(['/forum/<model("forum.forum"):forum>/new',
+                 '/forum/<model("forum.forum"):forum>/<model("forum.post"):post_parent>/reply'],
+                type='http', auth="public", methods=['POST'], website=True)
+    def post_create(self, forum, post_parent=None, post_type=None, **post):
+        cr, uid, context = request.cr, request.uid, request.context
         if not request.session.uid:
             return login_redirect()
-        request.registry['forum.post'].create(
-            request.cr, request.uid, {
-                'forum_id': forum.id,
-                'parent_id': post.id,
-                'content': kwargs.get('content'),
-            }, context=request.context)
-        return werkzeug.utils.redirect("/forum/%s/question/%s" % (slug(forum), slug(post)))
+        post_tag_ids = forum._tag_to_write_vals(post.get('post_tags', ''))
+        new_question = request.env['forum.post'].create({
+            'forum_id': forum.id,
+            'name': post.get('post_name', ''),
+            'content': post.get('content', False),
+            'content_link': post.get('content_link', False),
+            'parent_id': post_parent and post_parent.id or False,
+            'tag_ids': post_tag_ids,
+            'post_type': post_parent and post_parent.post_type or post_type,  # tde check in selection field
+        })
+        return werkzeug.utils.redirect("/forum/%s/question/%s" % (slug(forum), post_parent and slug(post_parent) or new_question.id))
 
     @http.route('/forum/<model("forum.forum"):forum>/post/<model("forum.post"):post>/comment', type='http', auth="public", methods=['POST'], website=True)
     def post_comment(self, forum, post, **kwargs):
         if not request.session.uid:
             return login_redirect()
         question = post.parent_id if post.parent_id else post
-        cr, uid, context = request.cr, request.uid, request.context
         if kwargs.get('comment') and post.forum_id.id == forum.id:
             # TDE FIXME: check that post_id is the question or one of its answers
-            request.registry['forum.post'].message_post(
-                cr, uid, post.id,
+            post.with_context(mail_create_nosubcribe=True).message_post(
                 body=kwargs.get('comment'),
                 type='comment',
-                subtype='mt_comment',
-                context=dict(context, mail_create_nosubcribe=True))
+                subtype='mt_comment')
         return werkzeug.utils.redirect("/forum/%s/question/%s" % (slug(forum), slug(question)))
 
     @http.route('/forum/<model("forum.forum"):forum>/post/<model("forum.post"):post>/toggle_correct', type='json', auth="public", website=True)
     def post_toggle_correct(self, forum, post, **kwargs):
-        cr, uid, context = request.cr, request.uid, request.context
         if post.parent_id is False:
             return request.redirect('/')
         if not request.session.uid:
             return {'error': 'anonymous_user'}
-        user = request.registry['res.users'].browse(request.cr, SUPERUSER_ID, request.uid, context=request.context)
-        if post.parent_id.create_uid.id != uid:
-            return {'error': 'own_post'}
-        if post.create_uid.id == user.id and user.karma < request.registry['forum.forum']._karma_answer_accept_own:
-            return {'error': 'not_enough_karma', 'karma': 20}
 
         # set all answers to False, only one can be accepted
-        request.registry['forum.post'].write(cr, uid, [c.id for c in post.parent_id.child_ids], {'is_correct': False}, context=context)
-        request.registry['forum.post'].write(cr, uid, [post.id], {'is_correct': not post.is_correct}, context=context)
-        return not post.is_correct
+        (post.parent_id.child_ids - post).write(dict(is_correct=False))
+        post.is_correct = not post.is_correct
+        return post.is_correct
 
     @http.route('/forum/<model("forum.forum"):forum>/post/<model("forum.post"):post>/delete', type='http', auth="user", methods=['POST'], website=True)
     def post_delete(self, forum, post, **kwargs):
-        check_res = self._has_enough_karma(post.create_uid.id == request.uid and '_karma_modo_unlink_own' or '_karma_modo_unlink_all')
-        if not check_res[0]:
-            return werkzeug.utils.redirect("/forum/%s" % slug(forum))
-
         question = post.parent_id
-        request.registry['forum.post'].unlink(request.cr, request.uid, [post.id], context=request.context)
+        post.unlink()
         if question:
             werkzeug.utils.redirect("/forum/%s/question/%s" % (slug(forum), slug(question)))
         return werkzeug.utils.redirect("/forum/%s" % slug(forum))
 
     @http.route('/forum/<model("forum.forum"):forum>/post/<model("forum.post"):post>/edit', type='http', auth="user", website=True)
     def post_edit(self, forum, post, **kwargs):
-        check_res = self._has_enough_karma(post.create_uid.id == request.uid and '_karma_modo_edit_own' or '_karma_modo_edit_all')
-        if not check_res[0]:
-            return werkzeug.utils.redirect("/forum/%s" % slug(forum))
-
-        tags = ""
-        for tag_name in post.tag_ids:
-            tags += tag_name.name + ","
+        tags = [dict(id=tag.id, name=tag.name) for tag in post.tag_ids]
+        tags = simplejson.dumps(tags)
         values = self._prepare_forum_values(forum=forum)
         values.update({
             'tags': tags,
@@ -388,24 +335,13 @@ class WebsiteForum(http.Controller):
 
     @http.route('/forum/<model("forum.forum"):forum>/post/<model("forum.post"):post>/save', type='http', auth="user", methods=['POST'], website=True)
     def post_save(self, forum, post, **kwargs):
-        cr, uid, context = request.cr, request.uid, request.context
-        question_tags = []
-        if kwargs.get('question_tag') and kwargs.get('question_tag').strip('[]'):
-            Tag = request.registry['forum.tag']
-            tags = kwargs.get('question_tag').strip('[]').replace('"', '').split(",")
-            for tag in tags:
-                tag_ids = Tag.search(cr, uid, [('name', '=', tag)], context=context)
-                if tag_ids:
-                    question_tags += tag_ids
-                else:
-                    new_tag = Tag.create(cr, uid, {'name': tag, 'forum_id': forum.id}, context=context)
-                    question_tags.append(new_tag)
+        post_tags = forum._tag_to_write_vals(kwargs.get('post_tag', ''))
         vals = {
-            'tag_ids': [(6, 0, question_tags)],
-            'name': kwargs.get('question_name'),
+            'tag_ids': post_tags,
+            'name': kwargs.get('post_name'),
             'content': kwargs.get('content'),
         }
-        request.registry['forum.post'].write(cr, uid, [post.id], vals, context=context)
+        post.write(vals)
         question = post.parent_id if post.parent_id else post
         return werkzeug.utils.redirect("/forum/%s/question/%s" % (slug(forum), slug(question)))
 
@@ -415,11 +351,8 @@ class WebsiteForum(http.Controller):
             return {'error': 'anonymous_user'}
         if request.uid == post.create_uid.id:
             return {'error': 'own_post'}
-        check_res = self._has_enough_karma('_karma_upvote')
-        if not check_res[0]:
-            return check_res[1]
         upvote = True if not post.user_vote > 0 else False
-        return request.registry['forum.post'].vote(request.cr, request.uid, [post.id], upvote=upvote, context=request.context)
+        return post.vote(upvote=upvote)
 
     @http.route('/forum/<model("forum.forum"):forum>/post/<model("forum.post"):post>/downvote', type='json', auth="public", website=True)
     def post_downvote(self, forum, post, **kwargs):
@@ -427,11 +360,8 @@ class WebsiteForum(http.Controller):
             return {'error': 'anonymous_user'}
         if request.uid == post.create_uid.id:
             return {'error': 'own_post'}
-        check_res = self._has_enough_karma('_karma_downvote')
-        if not check_res[0]:
-            return check_res[1]
         upvote = True if post.user_vote < 0 else False
-        return request.registry['forum.post'].vote(request.cr, request.uid, [post.id], upvote=upvote, context=request.context)
+        return post.vote(upvote=upvote)
 
     # User
     # --------------------------------------------------
@@ -440,18 +370,15 @@ class WebsiteForum(http.Controller):
                  '/forum/<model("forum.forum"):forum>/users/page/<int:page>'],
                 type='http', auth="public", website=True)
     def users(self, forum, page=1, **searches):
-        cr, uid, context = request.cr, request.uid, request.context
-        User = request.registry['res.users']
-
+        User = request.env['res.users']
         step = 30
-        tag_count = User.search(cr, SUPERUSER_ID, [('karma', '>', 1), ('website_published', '=', True)], count=True, context=context)
+        tag_count = len(User.search([('karma', '>', 1), ('website_published', '=', True)]))
         pager = request.website.pager(url="/forum/%s/users" % slug(forum), total=tag_count, page=page, step=step, scope=30)
-
-        obj_ids = User.search(cr, SUPERUSER_ID, [('karma', '>', 1), ('website_published', '=', True)], limit=step, offset=pager['offset'], order='karma DESC', context=context)
+        user_obj = User.sudo().search([('karma', '>', 1), ('website_published', '=', True)], limit=step, offset=pager['offset'], order='karma DESC')
         # put the users in block of 3 to display them as a table
-        users = [[] for i in range(len(obj_ids)/3+1)]
-        for index, user in enumerate(User.browse(cr, SUPERUSER_ID, obj_ids, context=context)):
-            users[index/3].append(user)
+        users = [[] for i in range(len(user_obj) / 3 + 1)]
+        for index, user in enumerate(user_obj):
+            users[index / 3].append(user)
         searches['users'] = 'True'
 
         values = self._prepare_forum_values(forum=forum, searches=searches)
@@ -466,99 +393,102 @@ class WebsiteForum(http.Controller):
 
     @http.route(['/forum/<model("forum.forum"):forum>/partner/<int:partner_id>'], type='http', auth="public", website=True)
     def open_partner(self, forum, partner_id=0, **post):
-        cr, uid, context = request.cr, request.uid, request.context
-        pids = request.registry['res.partner'].search(cr, SUPERUSER_ID, [('id', '=', partner_id)], context=context)
-        if pids:
-            partner = request.registry['res.partner'].browse(cr, SUPERUSER_ID, pids[0], context=context)
-            if partner.user_ids:
+        if partner_id:
+            partner = request.env['res.partner'].sudo().search([('id', '=', partner_id)])
+            if partner and partner.user_ids:
                 return werkzeug.utils.redirect("/forum/%s/user/%d" % (slug(forum), partner.user_ids[0].id))
         return werkzeug.utils.redirect("/forum/%s" % slug(forum))
 
     @http.route(['/forum/user/<int:user_id>/avatar'], type='http', auth="public", website=True)
     def user_avatar(self, user_id=0, **post):
-        cr, uid, context = request.cr, request.uid, request.context
         response = werkzeug.wrappers.Response()
-        User = request.registry['res.users']
-        Website = request.registry['website']
-        user = User.browse(cr, SUPERUSER_ID, user_id, context=context)
+        User = request.env['res.users']
+        Website = request.env['website']
+        user = User.sudo().search([('id', '=', user_id)])
         if not user.exists() or (user_id != request.session.uid and user.karma < 1):
             return Website._image_placeholder(response)
-        return Website._image(cr, SUPERUSER_ID, 'res.users', user.id, 'image', response)
+        return Website._image('res.users', user.id, 'image', response)
 
     @http.route(['/forum/<model("forum.forum"):forum>/user/<int:user_id>'], type='http', auth="public", website=True)
     def open_user(self, forum, user_id=0, **post):
-        cr, uid, context = request.cr, request.uid, request.context
-        User = request.registry['res.users']
-        Post = request.registry['forum.post']
-        Vote = request.registry['forum.post.vote']
-        Activity = request.registry['mail.message']
-        Followers = request.registry['mail.followers']
-        Data = request.registry["ir.model.data"]
-
-        user = User.browse(cr, SUPERUSER_ID, user_id, context=context)
+        User = request.env['res.users']
+        Post = request.env['forum.post']
+        Vote = request.env['forum.post.vote']
+        Activity = request.env['mail.message']
+        Followers = request.env['mail.followers']
+        Data = request.env["ir.model.data"]
+
+        user = User.sudo().search([('id', '=', user_id)])
+        if not user or user.karma < 1:
+            return werkzeug.utils.redirect("/forum/%s" % slug(forum))
         values = self._prepare_forum_values(forum=forum, **post)
-        if not user.exists() or (user_id != request.session.uid and (not user.website_published or user.karma < 1)):
+        if user_id != request.session.uid and not user.website_published:
             return request.website.render("website_forum.private_profile", values)
         # questions and answers by user
         user_questions, user_answers = [], []
-        user_post_ids = Post.search(
-            cr, uid, [
-                ('forum_id', '=', forum.id), ('create_uid', '=', user.id),
-                '|', ('active', '=', False), ('active', '=', True)], context=context)
-        user_posts = Post.browse(cr, uid, user_post_ids, context=context)
-        for record in user_posts:
-            if record.parent_id:
-                user_answers.append(record)
-            else:
-                user_questions.append(record)
+        user_question_ids = Post.search([
+            ('parent_id', '=', False),
+            ('forum_id', '=', forum.id), ('create_uid', '=', user.id)],
+            order='create_date desc')
+        count_user_questions = len(user_question_ids)
+        # displaying only the 20 most recent questions
+        user_questions = user_question_ids[:20]
+
+        user_answer_ids = Post.search([
+            ('parent_id', '!=', False),
+            ('forum_id', '=', forum.id), ('create_uid', '=', user.id)],
+            order='create_date desc')
+        count_user_answers = len(user_answer_ids)
+        # displaying only the 20  most recent answers
+        user_answers = user_answer_ids[:20]
 
         # showing questions which user following
-        obj_ids = Followers.search(cr, SUPERUSER_ID, [('res_model', '=', 'forum.post'), ('partner_id', '=', user.partner_id.id)], context=context)
-        post_ids = [follower.res_id for follower in Followers.browse(cr, SUPERUSER_ID, obj_ids, context=context)]
-        que_ids = Post.search(cr, uid, [('id', 'in', post_ids), ('forum_id', '=', forum.id), ('parent_id', '=', False)], context=context)
-        followed = Post.browse(cr, uid, que_ids, context=context)
+        post_ids = [follower.res_id for follower in Followers.sudo().search([('res_model', '=', 'forum.post'), ('partner_id', '=', user.partner_id.id)])]
+        followed = Post.search([('id', 'in', post_ids), ('forum_id', '=', forum.id), ('parent_id', '=', False)])
 
-        #showing Favourite questions of user.
-        fav_que_ids = Post.search(cr, uid, [('favourite_ids', '=', user.id), ('forum_id', '=', forum.id), ('parent_id', '=', False)], context=context)
-        favourite = Post.browse(cr, uid, fav_que_ids, context=context)
+        # showing Favourite questions of user.
+        favourite = Post.search([('favourite_ids', '=', user.id), ('forum_id', '=', forum.id), ('parent_id', '=', False)])
 
-        #votes which given on users questions and answers.
-        data = Vote.read_group(cr, uid, [('post_id.forum_id', '=', forum.id), ('post_id.create_uid', '=', user.id)], ["vote"], groupby=["vote"], context=context)
+        # votes which given on users questions and answers.
+        data = Vote.read_group([('forum_id', '=', forum.id), ('recipient_id', '=', user.id)], ["vote"], groupby=["vote"])
         up_votes, down_votes = 0, 0
         for rec in data:
             if rec['vote'] == '1':
                 up_votes = rec['vote_count']
             elif rec['vote'] == '-1':
                 down_votes = rec['vote_count']
-        total_votes = up_votes + down_votes
 
-        #Votes which given by users on others questions and answers.
-        post_votes = Vote.search(cr, uid, [('user_id', '=', user.id)], context=context)
-        vote_ids = Vote.browse(cr, uid, post_votes, context=context)
+        # Votes which given by users on others questions and answers.
+        vote_ids = Vote.search([('user_id', '=', user.id)])
 
-        #activity by user.
-        model, comment = Data.get_object_reference(cr, uid, 'mail', 'mt_comment')
-        activity_ids = Activity.search(cr, uid, [('res_id', 'in', user_post_ids), ('model', '=', 'forum.post'), ('subtype_id', '!=', comment)], order='date DESC', limit=100, context=context)
-        activities = Activity.browse(cr, uid, activity_ids, context=context)
+        # activity by user.
+        model, comment = Data.get_object_reference('mail', 'mt_comment')
+        activities = Activity.search([('res_id', 'in', (user_question_ids + user_answer_ids).ids), ('model', '=', 'forum.post'), ('subtype_id', '!=', comment)],
+                                     order='date DESC', limit=100)
 
         posts = {}
         for act in activities:
             posts[act.res_id] = True
-        posts_ids = Post.browse(cr, uid, posts.keys(), context=context)
+        posts_ids = Post.search([('id', 'in', posts.keys())])
         posts = dict(map(lambda x: (x.id, (x.parent_id or x, x.parent_id and x or False)), posts_ids))
 
-        post['users'] = 'True'
+        # TDE CLEANME MASTER: couldn't it be rewritten using a 'menu' key instead of one key for each menu ?
+        if user == request.env.user:
+            post['my_profile'] = True
+        else:
+            post['users'] = True
 
         values.update({
-            'uid': uid,
+            'uid': request.env.user.id,
             'user': user,
             'main_object': user,
             'searches': post,
             'questions': user_questions,
+            'count_questions': count_user_questions,
             'answers': user_answers,
+            'count_answers': count_user_answers,
             'followed': followed,
             'favourite': favourite,
-            'total_votes': total_votes,
             'up_votes': up_votes,
             'down_votes': down_votes,
             'activities': activities,
@@ -569,11 +499,10 @@ class WebsiteForum(http.Controller):
 
     @http.route('/forum/<model("forum.forum"):forum>/user/<model("res.users"):user>/edit', type='http', auth="user", website=True)
     def edit_profile(self, forum, user, **kwargs):
-        country = request.registry['res.country']
-        country_ids = country.search(request.cr, SUPERUSER_ID, [], context=request.context)
-        countries = country.browse(request.cr, SUPERUSER_ID, country_ids, context=request.context)
+        countries = request.env['res.country'].search([])
         values = self._prepare_forum_values(forum=forum, searches=kwargs)
         values.update({
+            'email_required': kwargs.get('email_required'),
             'countries': countries,
             'notifications': self._get_notifications(),
         })
@@ -581,14 +510,17 @@ class WebsiteForum(http.Controller):
 
     @http.route('/forum/<model("forum.forum"):forum>/user/<model("res.users"):user>/save', type='http', auth="user", methods=['POST'], website=True)
     def save_edited_profile(self, forum, user, **kwargs):
-        request.registry['res.users'].write(request.cr, request.uid, [user.id], {
+        values = {
             'name': kwargs.get('name'),
             'website': kwargs.get('website'),
             'email': kwargs.get('email'),
             'city': kwargs.get('city'),
-            'country_id': int(kwargs.get('country')),
+            'country_id': int(kwargs.get('country')) if kwargs.get('country') else False,
             'website_description': kwargs.get('description'),
-        }, context=request.context)
+        }
+        if request.uid == user.id:  # the controller allows to edit only its own privacy settings; use partner management for other cases
+            values['website_published'] = kwargs.get('website_published') == 'True'
+        user.write(values)
         return werkzeug.utils.redirect("/forum/%s/user/%d" % (slug(forum), user.id))
 
     # Badges
@@ -596,10 +528,8 @@ class WebsiteForum(http.Controller):
 
     @http.route('/forum/<model("forum.forum"):forum>/badge', type='http', auth="public", website=True)
     def badges(self, forum, **searches):
-        cr, uid, context = request.cr, request.uid, request.context
-        Badge = request.registry['gamification.badge']
-        badge_ids = Badge.search(cr, SUPERUSER_ID, [('challenge_ids.category', '=', 'forum')], context=context)
-        badges = Badge.browse(cr, uid, badge_ids, context=context)
+        Badge = request.env['gamification.badge']
+        badges = Badge.sudo().search([('challenge_ids.category', '=', 'forum')])
         badges = sorted(badges, key=lambda b: b.stat_count_distinct, reverse=True)
         values = self._prepare_forum_values(forum=forum, searches={'badges': True})
         values.update({
@@ -609,8 +539,7 @@ class WebsiteForum(http.Controller):
 
     @http.route(['''/forum/<model("forum.forum"):forum>/badge/<model("gamification.badge"):badge>'''], type='http', auth="public", website=True)
     def badge_users(self, forum, badge, **kwargs):
-        user_ids = [badge_user.user_id.id for badge_user in badge.owner_ids]
-        users = request.registry['res.users'].browse(request.cr, SUPERUSER_ID, user_ids, context=request.context)
+        users = [badge_user.user_id for badge_user in badge.sudo().owner_ids]
         values = self._prepare_forum_values(forum=forum, searches={'badges': True})
         values.update({
             'badge': badge,
@@ -621,26 +550,24 @@ class WebsiteForum(http.Controller):
     # Messaging
     # --------------------------------------------------
 
-    @http.route('/forum/<model("forum.forum"):forum>/post/<model("forum.post"):post>/comment/<model("mail.message"):comment>/convert_to_answer', type='http', auth="public", methods=['POST'], website=True)
+    @http.route('/forum/<model("forum.forum"):forum>/post/<model("forum.post"):post>/comment/<model("mail.message"):comment>/convert_to_answer', type='http', auth="user", methods=['POST'], website=True)
     def convert_comment_to_answer(self, forum, post, comment, **kwarg):
-        body = comment.body
-        request.registry['mail.message'].unlink(request.cr, request.uid, [comment.id], context=request.context)
+        post = request.env['forum.post'].convert_comment_to_answer(comment.id)
+        if not post:
+            return werkzeug.utils.redirect("/forum/%s" % slug(forum))
         question = post.parent_id if post.parent_id else post
-        for answer in question.child_ids:
-            if answer.create_uid.id == request.uid:
-                return self.post_comment(forum, answer, comment=html2plaintext(body))
-        return self.post_new(forum, question, content=body)
+        return werkzeug.utils.redirect("/forum/%s/question/%s" % (slug(forum), slug(question)))
 
     @http.route('/forum/<model("forum.forum"):forum>/post/<model("forum.post"):post>/convert_to_comment', type='http', auth="user", methods=['POST'], website=True)
     def convert_answer_to_comment(self, forum, post, **kwarg):
-        values = {
-            'comment': html2plaintext(post.content),
-        }
         question = post.parent_id
-        request.registry['forum.post'].unlink(request.cr, SUPERUSER_ID, [post.id], context=request.context)
-        return self.post_comment(forum, question, **values)
+        new_msg_id = post.convert_answer_to_comment()[0]
+        if not new_msg_id:
+            return werkzeug.utils.redirect("/forum/%s" % slug(forum))
+        return werkzeug.utils.redirect("/forum/%s/question/%s" % (slug(forum), slug(question)))
 
     @http.route('/forum/<model("forum.forum"):forum>/post/<model("forum.post"):post>/comment/<model("mail.message"):comment>/delete', type='json', auth="user", website=True)
     def delete_comment(self, forum, post, comment, **kwarg):
-        request.registry['mail.message'].unlink(request.cr, SUPERUSER_ID, [comment.id], context=request.context)
-        return True
+        if not request.session.uid:
+            return {'error': 'anonymous_user'}
+        return post.unlink_comment(comment.id)[0]