_description = "Action Reason"
_columns = {
'name': fields.char('Reason', size=64, required=True, help='Specifies the reason for Signing In/Signing Out.'),
- 'action_type': fields.selection([('sign_in', 'Sign in'), ('sign_out', 'Sign out')], "Action's type"),
+ 'action_type': fields.selection([('sign_in', 'Sign in'), ('sign_out', 'Sign out')], "Action Type"),
}
_defaults = {
'action_type': 'sign_in',
}
+
hr_action_reason()
def _employee_get(obj, cr, uid, context=None):
- if context is None:
- context = {}
ids = obj.pool.get('hr.employee').search(cr, uid, [('user_id', '=', uid)], context=context)
- if ids:
- return ids[0]
- return False
+ return ids and ids[0] or False
class hr_attendance(osv.osv):
_name = "hr.attendance"
_description = "Attendance"
def _day_compute(self, cr, uid, ids, fieldnames, args, context=None):
- if context is None:
- context = {}
res = dict.fromkeys(ids, '')
for obj in self.browse(cr, uid, ids, context=context):
res[obj.id] = time.strftime('%Y-%m-%d', time.strptime(obj.name, '%Y-%m-%d %H:%M:%S'))
_columns = {
'name': fields.datetime('Date', required=True, select=1),
'action': fields.selection([('sign_in', 'Sign In'), ('sign_out', 'Sign Out'), ('action','Action')], 'Action', required=True),
- 'action_desc': fields.many2one("hr.action.reason", "Action reason", domain="[('action_type', '=', action)]", help='Specifies the reason for Signing In/Signing Out in case of extra hours.'),
+ 'action_desc': fields.many2one("hr.action.reason", "Action Reason", domain="[('action_type', '=', action)]", help='Specifies the reason for Signing In/Signing Out in case of extra hours.'),
'employee_id': fields.many2one('hr.employee', "Employee's Name", required=True, select=True),
- 'day': fields.function(_day_compute, method=True, type='char', string='Day', store=True, select=1, size=32),
+ 'day': fields.function(_day_compute, type='char', string='Day', store=True, select=1, size=32),
}
_defaults = {
- 'name': lambda *a: time.strftime('%Y-%m-%d %H:%M:%S'), #Don't remove the lambda, if you remove it then the current time will not change
+ 'name': lambda *a: time.strftime('%Y-%m-%d %H:%M:%S'), #please don't remove the lambda, if you remove it then the current time will not change
'employee_id': _employee_get,
}
- def _altern_si_so(self, cr, uid, ids):
- for id in ids:
- sql = '''
- select action, name
- from hr_attendance as att
- where employee_id = (select employee_id from hr_attendance where id=%s)
- and action in ('sign_in','sign_out')
- and name <= (select name from hr_attendance where id=%s)
- order by name desc
- limit 2 '''
- cr.execute(sql,(id,id))
- atts = cr.fetchall()
- if not ((len(atts)==1 and atts[0][0] == 'sign_in') or (atts[0][0] != atts[1][0] and atts[0][1] != atts[1][1])):
+ def _altern_si_so(self, cr, uid, ids, context=None):
+ """ Alternance sign_in/sign_out check.
+ Previous (if exists) must be of opposite action.
+ Next (if exists) must be of opposite action.
+ """
+ for att in self.browse(cr, uid, ids, context=context):
+ # search and browse for first previous and first next records
+ prev_att_ids = self.search(cr, uid, [('employee_id', '=', att.employee_id.id), ('name', '<', att.name), ('action', 'in', ('sign_in', 'sign_out'))], limit=1, order='name DESC')
+ next_add_ids = self.search(cr, uid, [('employee_id', '=', att.employee_id.id), ('name', '>', att.name), ('action', 'in', ('sign_in', 'sign_out'))], limit=1, order='name ASC')
+ prev_atts = self.browse(cr, uid, prev_att_ids, context=context)
+ next_atts = self.browse(cr, uid, next_add_ids, context=context)
+ # check for alternance, return False if at least one condition is not satisfied
+ if prev_atts and prev_atts[0].action == att.action: # previous exists and is same action
+ return False
+ if next_atts and next_atts[0].action == att.action: # next exists and is same action
+ return False
+ if (not prev_atts) and (not next_atts) and att.action != 'sign_in': # first attendance must be sign_in
return False
return True
_constraints = [(_altern_si_so, 'Error: Sign in (resp. Sign out) must follow Sign out (resp. Sign in)', ['action'])]
_order = 'name desc'
+
hr_attendance()
class hr_employee(osv.osv):
_description = "Employee"
def _state(self, cr, uid, ids, name, args, context=None):
- if context is None:
- context = {}
result = {}
+ if not ids:
+ return result
for id in ids:
result[id] = 'absent'
cr.execute('SELECT hr_attendance.action, hr_attendance.employee_id \
return result
_columns = {
- 'state': fields.function(_state, method=True, type='selection', selection=[('absent', 'Absent'), ('present', 'Present')], string='Attendance'),
- }
+ 'state': fields.function(_state, type='selection', selection=[('absent', 'Absent'), ('present', 'Present')], string='Attendance'),
+ }
def _action_check(self, cr, uid, emp_id, dt=False, context=None):
- if context is None:
- context = {}
- cr.execute('select max(name) from hr_attendance where employee_id=%s', (emp_id,))
+ cr.execute('SELECT MAX(name) FROM hr_attendance WHERE employee_id=%s', (emp_id,))
res = cr.fetchone()
return not (res and (res[0]>=(dt or time.strftime('%Y-%m-%d %H:%M:%S'))))
def attendance_action_change(self, cr, uid, ids, type='action', context=None, dt=False, *args):
obj_attendance = self.pool.get('hr.attendance')
- if context is None:
- context = {}
id = False
warning_sign = 'sign'
res = {}
- #Special case when button calls this method :type=context
+ #Special case when button calls this method: type=context
if isinstance(type, dict):
type = type.get('type','action')
if type == 'sign_in':
raise osv.except_osv(_('Warning'), _('You tried to %s with a date anterior to another event !\nTry to contact the administrator to correct attendances.')%(warning_sign,))
res = {'action': type, 'employee_id': emp['id']}
-
if dt:
res['name'] = dt
- id = obj_attendance.create(cr, uid, res, context=context)
+ id = obj_attendance.create(cr, uid, res, context=context)
if type != 'action':
return id
-
return True
hr_employee()